Mercurial plugin not loaded with setuptools>=8

[Peter Suter]

Trac[loader] ERROR: Skipping "TracMercurial 1.0.0.6.dev0": (version conflict "ContextualVersionConflict: (trac 1.1.3dev-r13332, Requirement.parse('Trac>=1.0dev'), set(['TracMercurial']))"

The mercurial plugin requires Trac >=1.0dev​.

But it seems setuptools 8 has changed version parsing:

from pkg_resources import parse_version
parse_version('1.1.3dev-r13332') > parse_version('1.1dev')

In setuptools 7 and below this was True. In setuptools 8 and above this is False.

It seems one of these versions must be changed to be compliant with ​PEP:0440?

[Peter Suter]

​Apparently 1.1.3dev-r13332 should become 1.1.3.dev13332. In egg_info​ we can change tag_build from dev to .dev, but with tag_svn_revision setuptools adds the -r automatically so far. (Though since setuptools 10 that doesn't work anymore out of the box anyway.)

[Jun Omae]

The tag_svn_revision option requires ​pypi:setuptools_svn since setuptools 10.0. See ​https://bitbucket.org/pypa/setuptools/issue/313.

Even without the changing from dev to .dev, it seems that both version strings are compatible with ​PEP:0440 and the same value. Unfortunately, tag_svn_revision option currently generates incompatible version string with ​PEP:0440.

>>> import setuptools
>>> setuptools.__version__
'12.0.5'
>>> parse_version('1.0.3dev')
<Version('1.0.3.dev0')>
>>> parse_version('1.0.3.dev')
<Version('1.0.3.dev0')>
>>> parse_version('1.0.3dev') == parse_version('1.0.3.dev')
True
>>> parse_version('1.0.3dev-r12345')
<LegacyVersion('1.0.3dev-r12345')>
>>> parse_version('1.0.3.dev-r12345')
<LegacyVersion('1.0.3.dev-r12345')>

[Ryan J Ollos]

Replying to jomae:

Unfortunately, tag_svn_revision option currently generates incompatible version string with ​PEP:0440.

Given the issues we've seen with that option (e.g. ​th:#10778 seen with plugins - assuming a similar issue could be seen installing Trac), it seems better to just remove it. Do you guys agree?

[Peter Suter]

Replying to rjollos:

it seems better to just remove it. Do you guys agree?

Sadly yes, I don't see a good alternative.

[Jun Omae]

Replying to rjollos:

…, it seems better to just remove it. Do you guys agree?

Agreed. Otherwise, adding inherited egg_info command.

setup.py

@@ -15 +15 @@
 import sys
 
 from setuptools import setup, find_packages
+from setuptools.command.egg_info import egg_info
 
 min_python = (2, 6)
 if sys.version_info < min_python:
@@ -53 +54 @@
     # give some context to the warnings we might get when installing Genshi
 
 
+class svn_egg_info(egg_info):
+
+    def tags(self):
+        import re
+        return re.sub(r'\Adev-r([0-9]+)', r'dev\1', egg_info.tags(self))
+
+
+extra.setdefault('cmdclass', {})['egg_info'] = svn_egg_info
+
+
 setup(
     name = 'Trac',
     version = '1.1.4',

Of course, I don't recommend to use it because the base class of egg_info might be modified in the future.

$ PYTHONPATH=. /dev/shm/venv/bin/python setup.py egg_info
running egg_info
writing requirements to Trac.egg-info/requires.txt
writing Trac.egg-info/PKG-INFO
writing top-level names to Trac.egg-info/top_level.txt
writing dependency_links to Trac.egg-info/dependency_links.txt
writing entry points to Trac.egg-info/entry_points.txt
writing manifest file 'Trac.egg-info/SOURCES.txt'
$ grep '^Version:' Trac.egg-info/PKG-INFO
Version: 1.1.4.dev13863

[Ryan J Ollos]

Removed in [13902:13906]. I didn't look closely yet at whether #10658 should be closed.

[Peter Suter]

Seems to me both #10658 and this ticket can be closed. Please reopen if I missed something.

[Ryan J Ollos]

SpamFilter also has a tag_svn_revision in setup.cfg​.

[Ryan J Ollos]

Replying to rjollos:

SpamFilter also has a tag_svn_revision in setup.cfg​.

I opened #12038 after encountering a problem due to the invalid version number.