Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11994 closed defect (fixed)

Repository admin message assumes all non-editable repositories are defined in trac.ini

Reported by: anonymous Owned by: Jun Omae
Priority: normal Milestone: 1.0.6
Component: admin/web Version: 0.12
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed wrong message for non-editable repositories in repository manager.

API Changes:
Internal Changes:

Description

In TracRepositoryAdmin when you view a repository this message​ is shown for all non-editable repositories:

Note: This repository is defined in trac.ini and cannot be edited on this page.

But this is wrong and confusing. Not all such repositories are define repositories in trac.ini: They could be from repository providers like GitwebProjectsRepositoryProvider​ or ​th:HgDirManagerPlugin.

Attachments (0)

Change History (4)

comment:1 by Jun Omae, 10 years ago

Milestone: → 1.0.6
Owner: set to Jun Omae
Status: new → assigned
Version: → 0.12

Indeed.

  • trac/versioncontrol/templates/admin_repositories.html 

    diff --git a/trac/versioncontrol/templates/admin_repositories.html b/trac/versioncontrol/templates/admin_repositories.html
index ce8c84d..79a1016 100644
    a b  
    5454          <legend py:when="info.editable">Modify Repository:</legend>
    5555          <legend py:otherwise="">View Repository:</legend>
    5656          <p py:if="not info.editable" class="hint" i18n:msg=""><strong>Note:</strong>
    57             This repository is defined in <code><a href="${href.wiki('TracIni')}">trac.ini</a></code>
    58             and cannot be edited on this page.
     57            This repository is not defined in the database and cannot be edited on this page.
    5958          </p>
    6059          <div class="field">
    6160            <label>Name:<br/><input type="text" name="name" class="trac-autofocus"

comment:2 by Ryan J Ollos, 10 years ago

The change looks good to me.

comment:3 by Jun Omae, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed in [13947] and merged to trunk in [13948].

comment:4 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.