Edgewall Software
Modify

Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#12038 closed defect (fixed)

Version number is invalid

Reported by: Ryan J Ollos Owned by: Dirk Stöcker
Priority: normal Milestone: plugin - spam-filter
Component: plugin/spamfilter Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This is the same issue that was found with TracMercurial in #11993. Using tag_svn_revision in setup.cfg generates an invalid version string. Besides, it's not supported in setuptools ≥ 10.

The result is that tracfullblog.spamfilter doesn't load.

2015-04-24 08:01:00,789 Trac[loader] ERROR: Skipping "tracfullblog.spamfilter = tracfullblog.spamfilter [spamfilter]": (version conflict "VersionConflict: (TracSpamFilter 1.0.6dev-r0 (/srv/trac-hacks.org/pve/lib/python2.7/site-packages), Requirement.parse('TracSpamFilter>=0.2'))")
$ python
Python 2.7.9 (default, Feb 10 2015, 03:28:08) 
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>> setuptools.__version__
'12.0.5'
>>> from pkg_resources import parse_version
>>> parse_version('1.0.6dev-r0') > parse_version('0.2')
False

Attachments (0)

Change History (6)

comment:1 by Ryan J Ollos, 6 years ago

To avoid problems in the interim I have this line in my site install scripts, after extracting the source from the archive:

$ sed -i -e 's/tag_svn_revision = true//g' $src/spam-filter/setup.cfg

comment:2 by Ryan J Ollos, 6 years ago

I haven't tested, but it may be possible to retain the revision number in the package name by requiring setuptools_svn. This was suggested in the Setuptools release notes.

comment:3 by Ryan J Ollos, 6 years ago

Unrelated: Would you have any interest in publishing the package to PyPI?: https://pypi.python.org/pypi/TracSpamFilter

comment:4 by Ryan J Ollos, 6 years ago

Milestone: plugin - spam-filter

comment:5 by Ryan J Ollos, 6 years ago

Resolution: fixed
Status: newclosed

Fixed in [14337].

in reply to:  3 comment:6 by Ryan J Ollos, 6 years ago

Replying to rjollos:

Unrelated: Would you have any interest in publishing the package to PyPI?: https://pypi.python.org/pypi/TracSpamFilter

See #12270.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Dirk Stöcker to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.