Remove duplicate `link rel="icon"`

[anonymous]

Currently there are duplicated

<link rel="shortcut icon" href="/favicon.ico" type="image/x-icon" />
<link rel="icon" href="/favicon.ico" type="image/x-icon" />

Using shortcut icon only is enough if you want to keep IE compatibility. Also, since favicon.ico is in the root, it will work in all browsers regardless.

[Jun Omae]

Removing <link rel="shortcut icon" /> seems to be right if supported version of IE is 9.0+. See ​http://en.wikipedia.org/wiki/Favicon#How_to_use.

[Christian Boos]

Assuming IE 9+ on trunk seems reasonable.

[Peter Suter]

Is there a list of target browsers supported by Trac versions somewhere? I assume we should document this similar to supported versions of dependencies.

[Ryan J Ollos]

jQuery has a ​list of supported browsers, which is just one factor to consider when developing a list of supported browsers for Trac. The list of actively supported browsers in jQuery 2.x looks like a reasonable target for browser support in Trac 1.2.

[Ryan J Ollos]

Lately I've been thinking it would be useful to have a table showing the supported dependencies (and browsers) for all versions of Trac that are currently maintained.

[Ryan J Ollos]

Should we apply the change in milestone:1.1.5? … or even milestone:1.1.4?

[Jun Omae]

Should we apply the change in milestone:1.1.5? … or even milestone:1.1.4?

1.1.5 is okay to me.

If it is fixed in 1.0-stable, it would be good with the following:

trac/web/chrome.py

@@ -758 +758 @@
         if chrome['icon']:
             src = chrome['icon']['src']
             mimetype = chrome['icon']['mimetype']
-            add_link(req, 'icon', src, mimetype=mimetype)
-            add_link(req, 'shortcut icon', src, mimetype=mimetype)
+            if mimetype == 'image/x-icon':
+                add_link(req, 'shortcut icon', src)
+            else:
+                add_link(req, 'icon', src, mimetype=mimetype)
 
         # Logo image
         chrome['logo'] = self.get_logo_data(req.href, req.abs_href)

[Ryan J Ollos]

Fixed in [13936].

[Jun Omae]

I get the following error on my auto-build environments.

======================================================================
ERROR: test_icon_links (trac.web.tests.chrome.ChromeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/shm/52c4f3cabccc54744a7c40d5b2d1e1ed620eb786/py26-sqlite/trac/web/tests/chrome.py", line 258, in test_icon_links
    links['shortcut icon'][0]['href'])
KeyError: 'shortcut icon'

Fixed in [13938]. Please run make unit-test at least before commits.