Edgewall Software
Modify ↓

Opened 9 years ago

Closed 9 years ago

#11830 closed defect (fixed)

Editor symbols on history page are too large

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Reduced size of editor symbols on wiki history page.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

In comment:22:ticket:6573 it was noted that the icon-only buttons can be too large.

The proposed changes have captioned_button return a span with class trac-symbol or trac-text.

Attachments (2)

HistoryPage.png​ (74.5 KB ) - added by Ryan J Ollos 9 years ago.
HistoryPageBefore.png​ (78.7 KB ) - added by Ryan J Ollos 9 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Ryan J Ollos, 9 years ago

Description: modified (diff)
Summary: The captioned_button function should decorate return content with a class → Editor symbols on history page are too large

I misunderstood some things. The proposed change is very simple:

  • trac/htdocs/css/trac.css 

    diff --git a/trac/htdocs/css/trac.css b/trac/htdocs/css/trac.css
index e712dd3..f2c8764 100644
    a b table.listing pre { white-space: pre-wrap }  
    726726}
    727727#fieldhist td.version { text-align: center }
    728728#fieldhist td.comment { width: 100% }
     729.uisymbols #fieldhist .inlinebuttons a { font-size: 85% }
    729730
    730731#fieldhist .inlinebuttons {
    731732 display: none;

by Ryan J Ollos, 9 years ago

Attachment: HistoryPage.png​ added

comment:2 by Ryan J Ollos, 9 years ago

Description: modified (diff)

comment:3 by Christian Boos, 9 years ago

That looks good on all 3 browsers I've tested (FF, Chrome, IE).

by Ryan J Ollos, 9 years ago

Attachment: HistoryPageBefore.png​ added

comment:4 by Ryan J Ollos, 9 years ago

Description: modified (diff)
Status: new → assigned

Thanks for the review. I corrected the screen capture above to show before patch.

Here is the after patch.

comment:5 by Ryan J Ollos, 9 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Fixed in [13351].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.