Edgewall Software
Modify

Opened 5 years ago

Last modified 3 years ago

#11670 new enhancement

Wiki edit page should more clearly show when page doesn't exist

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-stable-1.2.x
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

Like the change that was made in #11663 for the Milestone Edit page, it would be more clear to use the green notification to indicate when the page does not exist.

Before:

After:

  • trac/wiki/templates/wiki_view.html

    diff --git a/trac/wiki/templates/wiki_view.html b/trac/wiki/templates/wiki_view.
    index 4797b6a..f4be55a 100644
    a b  
    7474          </div>
    7575        </py:when>
    7676        <py:otherwise>
    77           <p i18n:msg="name">The page ${name_of(page.resource)} does not exist.
    7877          <py:if test="higher">
    7978            <p>You could also create the same page higher in the hierarchy:</p>
    8079            <ul>
  • trac/wiki/web_ui.py

    diff --git a/trac/wiki/web_ui.py b/trac/wiki/web_ui.py
    index b524dba..a4d8dcb 100644
    a b class WikiModule(Component):  
    602602            if 'WIKI_CREATE' not in req.perm(page.resource):
    603603                raise ResourceNotFound(_('Page %(name)s not found',
    604604                                         name=page.name))
     605            add_notice(req, _("The page %(name)s does not exist. You can"
     606                              " create it here.", name=page.name))
    605607            formatter = OneLinerFormatter(self.env, context)
    606608            if '/' in page.name:
    607609                parts = page.name.split('/')

Attachments (2)

After.png (21.9 KB ) - added by Ryan J Ollos 5 years ago.
Before.png (20.8 KB ) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (4)

by Ryan J Ollos, 5 years ago

Attachment: After.png added

by Ryan J Ollos, 5 years ago

Attachment: Before.png added

comment:1 by Ryan J Ollos, 4 years ago

May not be needed after #11836.

comment:2 by Ryan J Ollos, 3 years ago

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.