more intuitive layout for wiki page create form

[Christian Boos]

The existing layout of the form is not optimal when creating a page inside a hierarchy, as it first proposes to create the page elsewhere, then further down has the button Create this page:

The links to "similar names" suggestions are already placed after the Create button, and I think it's better if we would also place the links for the non-existing pages higher in the hierarchy there. That way, users are less likely to follow these links "blindly":

[Christian Boos]

the wiki page creation form in 1.1.3

[Christian Boos]

the proposed wiki page creation form

[Christian Boos]

the proposed changes

[Ryan J Ollos]

A suggestion for another minor adjustment to the create page can be found in #11670.

[Christian Boos]

Replying to rjollos:

A suggestion for another minor adjustment to the create page can be found in #11670.

Ah sorry, I didn't remember that one otherwise I would have followed-up there. Still, I think that changing the order is clearer and makes the notice unnecessary.

Showing the #11670 proposal here for easier comparison:

Or combining the two ideas, we could indeed have "The page Foo/Bar doesn't exist. You can create it here" in a notice message, then the "Create" button and the template selector, followed by the links.

[Ryan J Ollos]

I think your proposed changes are good. I'd favor committing those, and waiting to see about #11670. Probably #11670 won't be needed.

[Christian Boos]

Ok, fine, thanks for the review! Patch applied in r13358 (trunk).

[Ryan J Ollos]

I fixed a few functional test cases in [13361]. Tests are currently failing though due to issue I introduced in #10984.

[Christian Boos]

Replying to rjollos:

I fixed a few functional test cases in [13361]. Tests are currently failing though due to issue I introduced in #10984.

Thanks! I thought I had run the test suite, but forgot that if it fails with the unit-tests it won't continue with the functional ones. And I had a few unrelated failures in the unit-tests (possibly due to a messed up version of Python). I'll be more careful next time.