Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11664 closed enhancement (fixed)

Improve layout of report edit page

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: ticket system Version:
Severity: normal Keywords: report
Cc:
Release Notes:

Improved styling of Report Edit page.

API Changes:

Description

The styling of the Report Edit page could be improved and made more consistent with other Trac pages by adding a fieldset and making some other minor changes. This was first mentioned in comment:10:ticket:11499.

Attachments (0)

Change History (11)

comment:1 Changed 4 years ago by Ryan J Ollos

It seems the message extraction does not work correctly for this case,

<title py:choose="">
  <py:when test="new_report" i18n:msg="">Create New Report</py:when>
  <py:otherwise i18n:msg="id,title">Edit Report {$report.id} $report.title</py:otherwise>
</title>

but does for this case,

<py:choose test="new_report">
  <title py:when="True">Create New Report</title>
  <title py:otherwise="" i18n:msg="id,title">Edit Report {$report.id} $report.title</title>
</py:choose>

Tested with Genshi 0.7.

comment:2 Changed 4 years ago by Ryan J Ollos

Proposed changes in log:rjollos.git:t11664. The last changeset on the branch ([b3f86bbf/rjollos.git])is a refactoring that is only intended for the trunk.

comment:3 Changed 4 years ago by Ryan J Ollos

Status: newassigned

comment:4 Changed 4 years ago by Ryan J Ollos

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

comment:5 Changed 4 years ago by Ryan J Ollos

Minor revisions in log:rjollos.git:t11664.1.

It could be better to apply these changes to trunk for the reason described in comment:13:ticket:11499, but the current styling of the Report Edit page is inconsistent with other pages, which might suggest this should be fixed on 1.0-stable.

comment:6 in reply to:  4 Changed 4 years ago by Jun Omae

Replying to rjollos:

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

Nothing is wrong to remove it. The width:100% property is used even if IE 6.

comment:7 Changed 4 years ago by Ryan J Ollos

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for the review. Committed to 1.0-stable in [12915], merged to trunk in [12916]. Refactoring committed to trunk in [12917].

comment:8 Changed 4 years ago by Ryan J Ollos

I regenerated the catalogs in [12918] and [12919], but I don't have permissions to upload them to Transifex.

Do the translation reports in the milestone descriptions reflect the state of the language po files? Most of those haven't been updated from the latest pot, so I would expect the report to have artificially high percentages for most languages.

comment:9 in reply to:  8 Changed 4 years ago by Jun Omae

I regenerated the catalogs in [12918] and [12919], but I don't have permissions to upload them to Transifex.

Same here. But it seems *.pot files is automatically fetched by transifex. See history in bottom of https://www.transifex.com/projects/p/trac/.

Do the translation reports in the milestone descriptions reflect the state of the language po files? Most of those haven't been updated from the latest pot, so I would expect the report to have artificially high percentages for most languages.

Yes, the reports seem to be right. I guess that most of translators probably work after announcing "string freeze". Also, in the group1 and group2 languages, translators have commit right and would directly push translations. In the group3 languages which translators have no commit right, we should commit *.po files from transifex.

comment:10 Changed 4 years ago by Ryan J Ollos

The following issue was noted in comment:6:ticket:11678.

It seems that the rule trunk/trac/htdocs/css/report.css@12954:96#L84 has no effect, but it would be good to have a small amout of spacing between the label and textarea.

Following the guidelines in this article, the following patch was generated:

  • trac/htdocs/css/report.css

    commit bb1f646e985cc6bb1b97605557fa9d51bd4b833c
    Author: rjollos <ryan.j.ollos@gmail.com>
    Date:   Mon Jul 21 11:05:33 2014 -0700
    
        Fixed display of padding below labels.
    
    diff --git a/trac/htdocs/css/report.css b/trac/htdocs/css/report.css
    index ee4439a..7c9060f 100644
    a b h2.report-result {  
    9393 max-width: 54em;
    9494}
    9595#content.report .field { margin: 1em 0; }
    96 #content.report .field label { padding-bottom: .3em; }
     96#content.report .field label {
     97 display: block;
     98 padding-bottom: .3em;
     99}
    97100
    98101#query { clear: right }
    99102#query fieldset, #query fieldset input, #query fieldset select {
  • trac/ticket/templates/report_edit.html

    diff --git a/trac/ticket/templates/report_edit.html b/trac/ticket/templates/repo
    index a15e4d7..2ceccb3 100644
    a b  
    3636          </legend>
    3737          <input type="hidden" name="action" value="$action" />
    3838          <div class="field">
    39             <label for="title">Title:</label><br />
     39            <label for="title">Title:</label>
    4040            <input type="text" id="title" name="title" class="trac-autofocus" v
    4141          </div>
    4242          <div class="field">
    4343            <label for="description" i18n:msg="">
    4444              Description: (you may use <a tabindex="42" href="${href.wiki('Wik
    45             </label><br />
     45            </label>
    4646            <textarea id="description" name="description" class="wikitext trac-
    4747$report.description</textarea>
    4848          </div>
    $report.description</textarea>  
    5252            </div>
    5353            <label for="query" i18n:msg="">Query: (can be either SQL or, if sta
    5454              a <a tabindex="42" href="${href.wiki('TracQuery') + '#QueryLangua
    55             </label><br />
     55            </label>
    5656            <textarea id="query" name="query" class="trac-resizable" rows="20"
    5757$report.sql</textarea>
    5858          </div>
Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:11 Changed 4 years ago by Ryan J Ollos

Change from comment:10 committed in [12981], merged in [12982].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.