Add a small amount of padding to textareas

[Ryan J Ollos]

Many of the textareas, including the ticket comment textarea, have padding: 0. One consequence is that underscores can be hidden when typing on the last line in the textarea. It would also be more visually appealing to have a small amount of padding, say 2px.

[Jun Omae]

Adding non-zero padding would lead textarea to overflow container when width: 100% for the textarea. However, if box-sizing: border-box is also added, good to me.

Also, we could remove negative margins from css/ticket.css by box-sizing: border-box.

-#comment { margin-left: -1px; margin-right: -1px; padding: 0; width: 100% }
+#comment { width: 100% }

[Ryan J Ollos]

Another issue to fix is that this rule​ doesn't work well with box-sizing: border-box. For example, on the report edit page after #11106, the input and textarea are shifted slightly to the right. I think we can add a trac-fullwidth class for textareas and inputs that has width: 100%, box-sizing: border-box, margin-left: 0 (and possibly other rules). Also, I think comment:20:ticket:11106 will be made irrelevant by these changes.

I will push the changes in #11499 before proposing these additional changes though.

[Ryan J Ollos]

Quick implementation in log:rjollos.git:t11678.1. I'll spend more time testing the changes tomorrow.

[Jun Omae]

Looks good to me. However, in [5e1db271/rjollos.git], I think we should add margin-right: 0 to .trac-fullwidth just like margin-left: 0.

trac/htdocs/css/trac.css

@@ -187 +187 @@
  -moz-box-sizing: border-box;
  box-sizing: border-box;
  margin-left: 0;
+ margin-right: 0;
  width: 100%;
 }
 textarea.trac-fullwidth { padding: 2px; }

[Ryan J Ollos]

It seems that the rule trunk/trac/htdocs/css/report.css@12954:96#L84​ has no effect, but it would be good to have a small amout of spacing between the label and textarea.

[Ryan J Ollos]

Committed to 1.0-stable in [12976], merged to trunk in [12977]. I incorporated the comment:5 suggestion. comment:6 will be addressed in #11664 (see comment:10:ticket:11664).