test_get_historian_with_unicode_path fails

[Christian Boos]

Test introduced in r11799.

On Linux, with git 1.8.1.4:

FAIL: test_get_historian_with_unicode_path (tracopt.versioncontrol.git.tests.PyGIT.UnicodeNameTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cboos/trac/1.0-stable/tracopt/versioncontrol/git/tests/PyGIT.py", line 300, in test_get_historian_with_unicode_path
    historian))
AssertionError: '37628107126171a5d01d4581486d2f59011406d6' != None

On Windows with git 1.7.7.msysgit.0 that test passes, so without having looked deeper I can't tell if the problem comes from the platform or the version of git.

[Jun Omae]

Humm, all unit tests pass with git 1.7.1 (git-1.7.1-3.el6_4.1.x86_64) and git 1.8.1.4 (installed from source) on CentOS 6.4.

[Christian Boos]

Ok, I'll have to dig deeper then. Thanks for the rapid feedback!

[Christian Boos]

Ryan also reported this problem in ticket:11180#comment:3.

[anonymous]

I just experienced this issue - any leads?

[Jun Omae]

I just catch it! Reproduced on Ubuntu 12 and git 1.7.9.5. The issue is caused by unexpected output of git log --name-status.

The paths of commits are quoted.

$ export LANG=en_US.UTF8
$ git --version
git version 1.7.9.5
$ git init /tmp/ticket11198
Initialized empty Git repository in /tmp/ticket11198/.git/
$ cd /tmp/ticket11198
$ git config user.name Joé
$ git config user.email joe@example.com
$ touch .gitignore
$ git add .gitignore
$ git commit -a -m test
[master (root-commit) cdbc5be] test
 0 files changed
 create mode 100644 .gitignore
$ touch tickét.txt
$ git add tickét.txt
$ git commit -a -m test
[master 2e06e52] test
 0 files changed
 create mode 100644 "tick\303\251t.txt"
$ git log --pretty=format:%n%H --name-status

2e06e5274b293c15e8f43d17e2f9595459861900
A       "tick\303\251t.txt"


cdbc5be781c73d5ab8fe4acf7137fd03d4ff1542
A       .gitignore

We expect that the paths are not quoted.

$ export LANG=en_US.UTF8
$ git --version
git version 1.8.2.1
$ git init /tmp/ticket11198
Initialized empty Git repository in /tmp/ticket11198/.git/
$ cd /tmp/ticket11198
$ git config user.name Joé
$ git config user.email joe@example.com
$ touch .gitignore
$ git add .gitignore
$ git commit -a -m test
[master (root-commit) d8e3cde] test
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 .gitignore
$ touch tickét.txt
$ git add tickét.txt
$ git commit -a -m test
[master 1ce4589] test
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 tickét.txt
$ git log --pretty=format:%n%H --name-status

1ce4589d571a1ceaed88aeffc63accfb949fe97e
A       tickét.txt


d8e3cde87d877ec0810d5c0314f10332bb83af43
A       .gitignore

This is the workaround for it.

tracopt/versioncontrol/git/PyGIT.py

@@ -87 +87 @@
 
         cmd = [self.__git_bin]
         if self.__git_dir:
-            cmd.append('--git-dir=%s' % self.__git_dir)
+            cmd.extend(('--git-dir=%s' % self.__git_dir,
+                       '-c', 'core.quotepath=false'))
         cmd.append(gitcmd)
         cmd.extend(args)
 

[Jun Omae]

Fixed in [11835].

[Jun Omae]

Oops, some failures with git package on CentOS 6.

FAILED (failures=3, errors=4)

The -c option is available since v1.7.2. The git package on CentOS 6 is v1.7.1….

$ cat /etc/redhat-release
CentOS release 6.4 (Final)
$ rpm -q git
git-1.7.1-3.el6_4.1.x86_64
$ /usr/bin/git --git-dir=/tmp/trac-gitrepos-Gi0lho/.git -c core.quotepath=false rev-parse --tags
Unknown option: -c
usage: git [--version] [--exec-path[=GIT_EXEC_PATH]] [--html-path]
           [-p|--paginate|--no-pager] [--no-replace-objects]
           [--bare] [--git-dir=GIT_DIR] [--work-tree=GIT_WORK_TREE]
           [--help] COMMAND [ARGS]

[Jun Omae]

Git command quotes control characters, double quote and backslash in paths to \t or \037 regardless of core.quotepath setting. We should unquote the paths.

Fixed in [11999-12000].