Show incorrect properties if the file has unicode path in git repository

[Jun Omae]

If a file has unicode path in a git repository, Trac shows the incorrect properties for the file.

attachment:unicode-path-in-git-repos.png​

Also, in that case, Python raises the following warning.

/home/jun66j5/src/trac/edgewall/tracopt/versioncontrol/git/PyGIT.py:884: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if next_path == [path]:

Patch:

tracopt/versioncontrol/git/PyGIT.py

@@ -866 +866 @@
         p = []
         change = {}
         next_path = []
+        base_path = self._fs_from_unicode(base_path)
 
         def name_status_gen():
             p[:] = [self.repo.log_pipe('--pretty=format:%n%H',
@@ -896 +897 @@
         gen = name_status_gen()
 
         def historian(path):
+            path = self._fs_from_unicode(path)
             try:
                 return change[path]
             except KeyError:

[Jun Omae]

Added the patch and unit tests in log:jomae.git:ticket11180/1.0.2dev. I'll push it.

[Jun Omae]

Committed in [11799].

[Ryan J Ollos]

The test doesn't seem to like being executed on my system (Ubuntu 12.04, Trac 1.0-stable). I'll have to do some debugging after I finish my current task, but just wanted to post this now in case the issue might be obvious.

======================================================================
FAIL: test_get_historian_with_unicode_path (tracopt.versioncontrol.git.tests.PyGIT.UnicodeNameTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/Workspace/t11117/trac.git/tracopt/versioncontrol/git/tests/PyGIT.py", line 300, in test_get_historian_with_unicode_path
    historian))
AssertionError: '39395ca8b6d84017a7e01fec6e113f173cc4d559' != None

----------------------------------------------------------------------
Ran 1351 tests in 25.460s

FAILED (failures=1)
Exception TypeError: "'NoneType' object is not callable" in <function <lambda> at 0xd07380c> ignored

$ git --version
git version 1.7.9.5

[Christian Boos]

Well, I haven't debugged it any further, but this is also what I've reported in #11198.