Edgewall Software
Modify

Opened 8 years ago

Closed 7 years ago

#11006 closed enhancement (fixed)

Add license headers to files in contrib, sample-plugins and doc

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: admin/console Version:
Severity: normal Keywords: license
Cc: gary.martin+trac@… Branch:
Release Notes:

Added license headers to files in contrib, sample-plugins and doc directories.

API Changes:
Internal Changes:

Description

As discussed on TracDev, license headers will be added to the files in contrib, as appropriate.

Attachments (0)

Change History (10)

comment:1 by gary.martin+trac@…, 8 years ago

Cc: gary.martin+trac@… added

comment:2 by Christian Boos, 8 years ago

Milestone: next-stable-1.0.x

comment:3 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Here is the summary, ignoring:

  • One-line scripts in the rpm directory.
  • ini files in workflow directory.

I can't seem any harm in adding headers to those as well, but it seems like a lot of clutter.

cgi-bin/trac.cgi Has license header
cgi-bin/trac.fcgi Has license header
workflow/migrate_original_to_basic.py Written by Eli Carter
workflow/showworkflow Written by Eli Carter
workflow/workflow_parser.py Written by Eli Carter
bugzilla2trac.py Written by Dmitry Yusupov (#224), source file lists many contributors
checkwiki.py Written by Daniel Lundin
emailfilter.py Written by Daniel Lundin
htdigest.py Has license header
htpasswd.py Written by Eli Carter
l10n_diff_index.py Written by Christian Boos
l10n_reset_en_GB.py Written by Christian Boos
l10n_revert_lineno_conflicts.py Written by Christian Boos
migrateticketmodel.py Written by Christoper Lenz
sourceforge2trac.py Written by Mark Rowe (#328)
trac-pre-commit-hook Written by Jonas Borgström
trac-svn-hook Written by Christian Boos
trac-svn-post-commit-hook.cmd Written by Christian Boos and Markus Tacker (#1310 and #1602)

To summarize, all of the files appear to have been written by a current or past TracTeam member, with the exception of the 2 bold entries. Should there be any question about the license for those 2?

There were some tabs in bugzilla2trac.py; patch in 96f8401c.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Summary: Add license headers to files in contribAdd license headers to files in contrib, sample-plugins and doc

Expanding scope of ticket:

  • 39eed57f: Added license headers to py files in doc directory.
  • 803d88e3: Added license headers to py files in the sample-plugins directory.

One outlier is that trunk/sample-plugins/workflow/MilestoneOperation.py@11493 has a Beer-Ware license.

comment:5 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.x1.0.2
Owner: set to Ryan J Ollos
Status: newassigned

I'll push ahead with this for 1.0.2 unless anyone sees a problem. Regarding the two unlicensed files that weren't written by TracTeam members, I'll attempt to get in touch with the authors.

comment:6 by Ryan J Ollos, 7 years ago

Keywords: license added

in reply to:  5 comment:7 by Ryan J Ollos, 7 years ago

Replying to rjollos:

I'll push ahead with this for 1.0.2 unless anyone sees a problem. Regarding the two unlicensed files that weren't written by TracTeam members, I'll attempt to get in touch with the authors.

Now that I think about it some more, the contribution of trac-svn-post-commit-hook.cmd is really no different than any other file or change in the Trac codebase. The file was contributed through a ticket and committed by a Trac team member. Same with bugzilla2trac.py.

MilestoneOperation.py is an outlier though, because it was contributed and accepted with a different license in the file header (BeerWare). I've contacted the author about changing this to 3-Clause BSD, just so that we have consistency in the codebase.

comment:8 by Ryan J Ollos, 7 years ago

Proposed changes can be found in rjollos.git:t11006.2. I'm waiting to see if I get feedback on the license issue for MilestoneOperation.py and then I'll commit the changes.

comment:9 by anonymous, 7 years ago

Hi Ryan, here's Franz, author of MilestoneOperation.py. You're welcome to change the license to BSD-lincense.

comment:10 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12164:12165], and merged to trunk in [12166].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.