Opened 12 years ago
Closed 11 years ago
#11006 closed enhancement (fixed)
Add license headers to files in contrib, sample-plugins and doc
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.2 |
Component: | admin/console | Version: | |
Severity: | normal | Keywords: | license |
Cc: | gary.martin+trac@… | Branch: | |
Release Notes: |
Added license headers to files in contrib, sample-plugins and doc directories. |
||
API Changes: | |||
Internal Changes: |
Description
As discussed on TracDev, license headers will be added to the files in contrib
, as appropriate.
Attachments (0)
Change History (10)
comment:1 by , 12 years ago
Cc: | added |
---|
comment:2 by , 12 years ago
Milestone: | → next-stable-1.0.x |
---|
comment:4 by , 12 years ago
Summary: | Add license headers to files in contrib → Add license headers to files in contrib, sample-plugins and doc |
---|
Expanding scope of ticket:
- 39eed57f: Added license headers to
py
files indoc
directory. - 803d88e3: Added license headers to
py
files in thesample-plugins
directory.
One outlier is that trunk/sample-plugins/workflow/MilestoneOperation.py@11493 has a Beer-Ware license.
follow-up: 7 comment:5 by , 11 years ago
Milestone: | next-stable-1.0.x → 1.0.2 |
---|---|
Owner: | set to |
Status: | new → assigned |
comment:6 by , 11 years ago
Keywords: | license added |
---|
comment:7 by , 11 years ago
Replying to rjollos:
I'll push ahead with this for 1.0.2 unless anyone sees a problem. Regarding the two unlicensed files that weren't written by TracTeam members, I'll attempt to get in touch with the authors.
Now that I think about it some more, the contribution of trac-svn-post-commit-hook.cmd
is really no different than any other file or change in the Trac codebase. The file was contributed through a ticket and committed by a Trac team member. Same with bugzilla2trac.py
.
MilestoneOperation.py
is an outlier though, because it was contributed and accepted with a different license in the file header (BeerWare). I've contacted the author about changing this to 3-Clause BSD, just so that we have consistency in the codebase.
comment:8 by , 11 years ago
Proposed changes can be found in rjollos.git:t11006.2. I'm waiting to see if I get feedback on the license issue for MilestoneOperation.py
and then I'll commit the changes.
comment:9 by , 11 years ago
Hi Ryan, here's Franz, author of MilestoneOperation.py
. You're welcome to change the license to BSD-lincense.
comment:10 by , 11 years ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Committed to 1.0-stable in [12164:12165], and merged to trunk in [12166].
Here is the summary, ignoring:
rpm
directory.ini
files inworkflow
directory.I can't seem any harm in adding headers to those as well, but it seems like a lot of clutter.
cgi-bin/trac.cgi
cgi-bin/trac.fcgi
workflow/migrate_original_to_basic.py
workflow/showworkflow
workflow/workflow_parser.py
bugzilla2trac.py
checkwiki.py
emailfilter.py
htdigest.py
htpasswd.py
l10n_diff_index.py
l10n_reset_en_GB.py
l10n_revert_lineno_conflicts.py
migrateticketmodel.py
sourceforge2trac.py
trac-pre-commit-hook
trac-svn-hook
trac-svn-post-commit-hook.cmd
To summarize, all of the files appear to have been written by a current or past TracTeam member, with the exception of the 2 bold entries. Should there be any question about the license for those 2?
There were some tabs in
bugzilla2trac.py
; patch in 96f8401c.