Edgewall Software
Modify

Opened 20 years ago

Closed 19 years ago

#1092 closed defect (duplicate)

Browser gets None from fs.revision_prop(LOG)

Reported by: bkc@… Owned by: Jonas Borgström
Priority: normal Milestone:
Component: version control/browser Version: 0.8
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christopher Lenz)

It looks like Browser.py fails because this line (about line 89 in Browser.py) returns None

change = svn.fs.revision_prop(self.fs_ptr, created_rev,
   svn.util.SVN_PROP_REVISION_LOG,
   self.pool)

I'm running subversion 1.1.2 on RHEL3 (and a damn nightmare it was getting python bindings to work)

Anyway, 'change' is None in some cases, generating this traceback:

Traceback (most recent call last):
  File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 525, in cgi_start
    real_cgi_start()
  File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 520, in real_cgi_start
    dispatch_request(path_info, args, req, env)
  File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 435, in dispatch_request
    module.run()
  File "/usr/local/lib/python2.3/site-packages/trac/Module.py", line 44, in run
    self.render()
  File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line 172, in render
    info = self.get_info(path, rev, rev_specified)
  File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line 92, in get_info
    item = {
  File "/usr/local/lib/python2.3/site-packages/trac/util.py", line 62, in wiki_escape_newline
    return text.replace(os.linesep, '[[BR]]' + os.linesep)
AttributeError: 'NoneType' object has no attribute 'replace'

My temporary fix is this:

 change = svn.fs.revision_prop(self.fs_ptr, created_rev,
    svn.util.SVN_PROP_REVISION_LOG,
    self.pool) or ''

Attachments (0)

Change History (2)

comment:1 by Christopher Lenz, 20 years ago

Description: modified (diff)
Keywords: NoneType removed

(Made the code snippets and traceback in the description readable)

comment:2 by Christian Boos, 19 years ago

Resolution: duplicate
Status: newclosed

#1092 and #1093 were actually duplicates (same reporter, similar issue, this one in the Browser, the other one in the Log view)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.