Modify ↓
Opened 21 years ago
Closed 20 years ago
#1093 closed defect (fixed)
Log.Log.log_receiver gets None for log from subversion
| Reported by: | Owned by: | Jonas Borgström | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | version control/log view | Version: | 0.8 |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
With subversion 1.1.2, viewing the revision history of a directory, I get this traceback:
Traceback (most recent call last):
File "/usr/local/lib/python2.3/site-packages/trac/ModPythonHandler.py", line 194, in handler
core.dispatch_request(mpr.path_info, args, mpr, env)
File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 435, in dispatch_request
module.run()
File "/usr/local/lib/python2.3/site-packages/trac/Module.py", line 44, in run
self.render()
File "/usr/local/lib/python2.3/site-packages/trac/Log.py", line 144, in render
info = self.get_info (self.path, rev)
File "/usr/local/lib/python2.3/site-packages/trac/Log.py", line 70, in get_info
self.pool)
File "/usr/local/lib/python2.3/site-packages/trac/Log.py", line 45, in log_receiver
shortlog = util.shorten_line(util.wiki_escape_newline(log))
File "/usr/local/lib/python2.3/site-packages/trac/util.py", line 62, in wiki_escape_newline
return text.replace(os.linesep, '[[BR]]' + os.linesep)
AttributeError: 'NoneType' object has no attribute 'replace'
It seems that 'log' is None in the callback from subversion to log_receiver().
My fix was to change (in two places in log_receiver) calls to wiki_escape_newline(log) to be wiki_escape_newline(log or '')
Attachments (0)
Change History (3)
comment:1 by , 21 years ago
comment:2 by , 21 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | NoneType removed |
(Tidying description)
comment:3 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
It seems that now we are using .message or '--'
whereever appropriate.
Note:
See TracTickets
for help on using tickets.



I cannot reproduce that problem here with Subversion 1.1.2. Anyone else?