Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#10804 closed defect (fixed)

layout glitch in timeline changeset event for FF

Reported by: Christian Boos Owned by: Jun Omae
Priority: normal Milestone: 1.0
Component: timeline Version: 1.0b1
Severity: minor Keywords: css firefox
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It happens only with FF, afaict:

rendering of Trac changesets showing incremental indent for each file entry

If anyone has an idea…

Attachments (1)

changeset_show_files_3.png (28.2 KB ) - added by Christian Boos 12 years ago.
rendering of Trac changesets showing incremental indent for each file entry

Download all attachments as: .zip

Change History (8)

by Christian Boos, 12 years ago

Attachment: changeset_show_files_3.png added

rendering of Trac changesets showing incremental indent for each file entry

comment:1 by Christian Boos, 12 years ago

In TracIni:

[timeline]
changeset_show_files = 3

comment:2 by Jun Omae, 12 years ago

I cannot reproduce the issue for me. However, it seems that it caused by float: left.

[ae060fd1/jomae.git] uses display: inline-block instead. Confirmed with IE 7-8, Firefox 14, Chrome 21 beta, Safari 5.1 and Opera 12.

comment:3 by Christian Boos, 12 years ago

Wow, impressive! Yes, right on the spot, it was the float and you couldn't reproduce it as I forgot to tell you that I had set the minimum font size to 13pt (I had forgotten as well…).

So your fix works for me, I would just suggest adding a vertical-align of middle, as the alignment looks nicer that way (in fact, like it used to do before).

comment:4 by Jun Omae, 12 years ago

Oh, Thanks. I reproduced it now. I confirmed your suggestion with all browsers. Looks good!

comment:5 by Christian Boos, 12 years ago

Version: 1.0dev1.0b1

Feel free to apply both changes, then!

comment:6 by Jun Omae, 12 years ago

Milestone: next-stable-1.0.x1.0
Resolution: fixed
Status: newclosed

Applied in [11200].

comment:7 by Jun Omae, 12 years ago

Owner: set to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.