Can't download attached file when filename contain 'space'.

[buaa.byl@…]

First I attache a file "processor reference.pdf" to wiki. Then I found the filename save to disk is "processor%20reference.pdf".

And url from wiki is "​http://127.0.0.1:8008/trac/knowledge/attachment/wiki/instruction_of_picoblaze/processor%20reference.pdf"

but I can not download it, browser show '404 not found' when I click it.

When I rename the filename from "processor%20reference.pdf" to "processor reference.pdf".

Then I clkick url, the url is valid, I can download it.

So, maybe it is a bug?

I use version 0.12.3 of trac and browser is opera.

[Christian Boos]

If you're using tracd behind another web server, then please have a look at TracStandalone#Usingtracdbehindaproxy.

[buaa.byl@…]

Replying to cboos:

If you're using tracd behind another web server, then please have a look at TracStandalone#Usingtracdbehindaproxy.

I use apache2.2.17 + mod_wsgi3.3, not tracd.

[Christian Boos]

dummy file

[Christian Boos]

another dummy file… this time with no spaces but actual "%20" sequences of 3 characters

[Christian Boos]

The above attachment contains real spaces in its filename. Now try to download it using:

​http://trac.edgewall.org/attachment/ticket/10801/filename%20with%20spaces.pdf

… it works, at least in FF. This is a browser "feature" I suppose.

If the file would really contain the "%20" sequence of characters, we would need to double encode it:

​http://trac.edgewall.org/attachment/ticket/10801/filename%2520with%2520spaces.pdf

[buaa.byl@…]

I can download your "filename with spaces.pdf" from chrome/IE/firefox/opera.

But my file still can't download with neither chrome/IE/firefox/opera. ​http://127.0.0.1:8008/trac/knowledge/raw-attachment/wiki/instruction_of_picoblaze/PicoBlaze%20Intructions.xlsx

Every browser response"The requested URL /trac/knowledge/raw-attachment/wiki/instruction_of_picoblaze/PicoBlaze Intructions.xlsx was not found on this server.".

If I rename the file from PicoBlaze%20Instructions.xlsx to PicoBlaze Instruction.xlsx, then I can download ​http://127.0.0.1:8008/trac/knowledge/raw-attachment/wiki/instruction_of_picoblaze/PicoBlaze%20Intructions.xlsx

from every browser.

But ​http://127.0.0.1:8008/trac/knowledge/attachment/wiki/instruction_of_picoblaze/PicoBlaze%20Intructions.xlsx response Attachment 'PicoBlaze Intructions.xlsx' not found

I upload a file name test out.txt, I can view in preview, but still can't download in Original Format.

[buaa.byl@…]

By the way, file contant space can download after attach to a ticket:) This problem just appear in wiki attachment.

[Christian Boos]

(forgot to finish my example, will go back to what has been added in comment:5 a bit later …)

In fact it's probably not browser specific, as the other browsers I tested behave the same.

Anyway, we already do this double encoding, as you can see from the Attachments links above and from those generated by the TracLinks syntax:

 - [attachment:filename%20with%20spaces.pdf]
 - [attachment:"filename with spaces.pdf"]

• filename%20with%20spaces.pdf​
• filename with spaces.pdf​

[Christian Boos]

Replying to buaa.byl@…:

By the way, file contant space can download after attach to a ticket:) This problem just appear in wiki attachment.

Could you try with demo-0.13/wiki/Testing10801?

[buaa.byl@…]

Both ie and chrome can download two attachment from ​demo-0.13/wiki/Testing10801.

[Christian Boos]

So, to summarize, if in your Trac, you have the following URL:
​http://127.0.0.1:8008/trac/knowledge/attachment/wiki/instruction_of_picoblaze/processor%20reference.pdf
but the filename of that attachment is processor%20reference.pdf, then it's normal that you can't access the file in this case, as this URL refers to the file named processor reference.pdf.

This is the same as what you can see here, with the URL:
​http://trac.edgewall.org/demo-0.13/attachment/wiki/Testing10801/filename%20with%20spaces.pdf
which refers to filename with spaces.pdf (and not to filename%20with%20spaces.pdf).

So the question is, what generates the URL ending with "…/processor%20reference.pdf" on your system?

• does that really come from the list of attachments found in your instruction_of_picoblaze wiki page, as your comment:5 imply? Please show us the relevant HTML excerpt, as that would seem to contradict what can be seen in demo-0.13/wiki/Testing10801 (or even demo-0.12/wiki/Testing10801).
• or does that URL come from an [attachment:...] TracLinks? Maybe you wrote [attachment:processor%20reference.pdf]?
• by any chance, do you use a plugin that could mess with the list of attachments? Try disabling temporarily your plugins, just to be sure.

[buaa.byl@…]

Replying to cboos:

So, to summarize, if in your Trac, you have the following URL:
​http://127.0.0.1:8008/trac/knowledge/attachment/wiki/instruction_of_picoblaze/processor%20reference.pdf
but the filename of that attachment is processor%20reference.pdf, then it's normal that you can't access the file in this case, as this URL refers to the file named processor reference.pdf.

This is the same as what you can see here, with the URL:
​http://trac.edgewall.org/demo-0.13/attachment/wiki/Testing10801/filename%20with%20spaces.pdf
which refers to filename with spaces.pdf (and not to filename%20with%20spaces.pdf).

So the question is, what generates the URL ending with "…/processor%20reference.pdf" on your system?

• does that really come from the list of attachments found in your instruction_of_picoblaze wiki page, as your comment:5 imply? Please show us the relevant HTML excerpt, as that would seem to contradict what can be seen in demo-0.13/wiki/Testing10801 (or even demo-0.12/wiki/Testing10801).
• or does that URL come from an [attachment:...] TracLinks? Maybe you wrote [attachment:processor%20reference.pdf]?
• by any chance, do you use a plugin that could mess with the list of attachments? Try disabling temporarily your plugins, just to be sure.

I have two trac system, one is in my pc, the other is in company.

• Trac on my pc is Windows7 + apache2.2.22 + mod_wsgi3.3 + python2.7.2 + php5.4,issue on this.
• Trac on company is Debian5 + apache2.2.9 + mod_wsgi3.3 + python2.5.2 + php5.2.

And I test like that : attach a file named "test space.txt" to WikiStart, and click the bottom atachment list, and click "test space.txt", both two system can preview file, then I click origianl format, trac on windows show The requested URL /trac/public/raw-attachment/wiki/WikiStart/test space.txt was not found on this server., and trac on debian5 is ok.

And both file name in disk is /trac/tracpool/public/attachments/wiki/WikiStart/test%20space.txt and Apache\trachome\public\attachments\wiki\WikiStart\test%20space.txt

[Christian Boos]

Ok, I guess I need to see by myself…

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed