Mercurial bookmarks as properties in browser

[Peter Suter]

It would be nice if the TracMercurial plugin would show bookmarks as properties on TracChangeset pages.

This seems quite simple:

backend.py

@@ -174 +174 @@
 
     def match_property(self, name, mode):
         return (name.startswith('hg-') and
-                name[3:] in ('Parents', 'Children', 'Tags', 'Branch') and
+                name[3:] in ('Parents', 'Children', 'Tags', 'Branch',
+                             'Bookmarks') and
                 mode == 'revprop') and 4 or 0
     
     def render_property(self, name, mode, context, props):
@@ -1189 +1190 @@
         tags = self.get_tags()
         if len(tags):
             properties['hg-Tags'] = (self.repos, tags) 
+        bookmarks = self.ctx.bookmarks()
+        if len(bookmarks):
+            properties['hg-Bookmarks'] = (self.repos, bookmarks) 
         for k, v in self.ctx.extra().iteritems():
             if k != 'branch':
                 properties['hg-' + k] = (self.repos, v)

Unfortunately there is a catch: Changeset pages are cached​, but modifying a bookmark currently does not invalidate that cache.

[Christian Boos]

Replying to psuter:

It would be nice if the TracMercurial plugin would show bookmarks as properties on

As properties, and also in the TracBrowser view, same as we do for tags and branches (in blue?).

Unfortunately there is a catch: Changeset pages are cached​, but modifying a bookmark currently does not invalidate that cache.

What about adding all the properties in the mix?

In the meantime, I already added the above in [f261cc084df2/mercurial-plugin].

[pbuck@…]

need to catch lack of bookmarks (if extension not configured in HG). Suggest something like

  try:
    bookmarks = self.ctx.bookmarks()
  except AttributeError:
    bookmarks = []

… I don't have bookmarks enabled, so I can't say if this is good otherwise.

[Christian Boos]

Oops, didn't see (or paid attention to) the above comment, and now we have #10908 :-(

[pykler@…]

Should bookmarks appear under the dropdown for branches and tags, it doesn't for me and following the code does not seem to point that it would.

Since bookmarks are lightweight branches it would be nice if this is possible.

[anonymous]

Replying to pykler@…:

Should bookmarks appear under the dropdown for branches and tags, it doesn't for me and following the code does not seem to point that it would.

Looks like changeset:d1913701fd5b/mercurial-plugin implemented this.

I would love to also see the bookmarks in the TracRevisionLog, similar to branch heads and tags.

[Peter Suter]

The first patch​ for Trac itself adds a new API method Changeset.get_bookmarks() and uses it to show bookmarks as blue labels on the revision log, browser pages and timeline (just like Changeset.get_tags()).

The second patch​ for the mercurial-plugin simply implements that API.

Should I open a new ticket for the first patch targeting Trac 1.1.5?

[Ryan J Ollos]

Replying to psuter:

Should I open a new ticket for the first patch targeting Trac 1.1.5?

That seems like a good idea so that we have an API Changes entry for 1.1.5.

[Peter Suter]

Right, I created #11995 for that.

[Peter Suter]

Committed in changeset:779abf179cee/mercurial-plugin.