AttributeError: 'changectx' object has no attribute 'bookmarks'

[r.rossmair]

This error is issued by TracMercurial 1.0.0.3dev every time I want to view a changeset. Used to work until recently, apparently a Trac or TracMercurial update broke things.

Trac revision is 11406.

While doing a GET operation on /changeset/b6da56b443c458c07b51b720f9a2e777deff6beb/visureal-classic, Trac issued an internal error.

Request parameters:

{ new : u b6da56b443c458c07b51b720f9a2e777deff6beb ,   new_path : u /visureal-classic } 

User agent: Mozilla/5.0 Windows NT 6.1; WOW64; rv:17.0 Gecko/17.0 Firefox/17.0

System Information

Trac	1.0.1dev-r0
Babel	0.9.6
Genshi	0.6 without speedups
Mercurial	1.6.4
mod_wsgi	3.3 WSGIProcessGroup WSGIApplicationGroup %{GLOBAL}
Pygments	1.3.1
pysqlite	2.6.0
Python	2.6.6 r266:84292, Dec 27 2010, 00:18:12 br GCC 4.4.5
setuptools	0.6
SQLite	3.7.3
Subversion	1.7.7 r1393599
jQuery	1.7.2

Enabled Plugins

TracMercurial

1.0.0.3dev

Python Traceback

Traceback  most recent call last :  
 ...
File  /usr/local/lib/python2.6/dist-packages/Trac-1.0.1dev_r0-py2.6.egg/trac/versioncontrol/web_ui/changeset.py , line 427, in _render_html
  revprops   chgset.get_properties    
File  /usr/local/lib/python2.6/dist-packages/TracMercurial-1.0.0.3dev-py2.6.egg/tracext/hg/backend.py , line 1223, in get_properties
  bookmarks   self.ctx.bookmarks   AttributeError:  changectx  object has no attribute  bookmarks  

[Christian Boos]

Fixing the "newline character is missing from my charset" issue in the description…

[Christian Boos]

Well, Mercurial 1.6.4 is a bit too old for the newest version of the plugin. I see that we still have compatible with ≥ 1.1.x written in TracMercurial however.

We can add a check in the code for the presence of the bookmarks method, but I wonder if you're not going to run into other issues…

[Christian Boos]

The following quick hack works…

tracext/hg/backend.py

@@ -1214 +1214 @@
         tags = self.get_tags()
         if len(tags):
             properties['hg-Tags'] = (self.repos, tags) 
-        bookmarks = self.ctx.bookmarks()
+        bookmarks = self.ctx.bookmarks() if hasattr(self.ctx, 'bookmarks') \
+            else ()
         if len(bookmarks):
             properties['hg-Bookmarks'] = (self.repos, bookmarks) 
         for k, v in self.ctx.extra().iteritems():

Maybe someone has a better idea for checking for bookmark support, if not I'll commit something like that.

[Christian Boos]

(Another) quick hack committed as [8df754d9b36a/mercurial-plugin].

[Christian Boos]

PS: don't hesitate to open other tickets if you find other problems with Mercurial 1.6.4, as it's been a while I haven't test the older versions.

[r.rossmair]

Thank you, that did it.

Mercurial 1.6.4 is the package version in Debian squeeze. I'm thinking about installing the package from backports however, given that with 1.6.4 apparently problems are more likely to arise.