Support for integer/float custom fields

[pipern]

See ​http://article.gmane.org/gmane.comp.version-control.subversion.trac.devel/6561 for some discussion.

We'd like to be able to mark some custom fields as "contains integer" or "contains floating number". This would then let us sort numerically, validate user input, add an aggregation/summing feature, and so on.

We're not thinking of changing the storage type, nor, currently, the Python type that exists in the ticket.fields list. Instead, we just validate the user input and then later we can also attempt to convert the field value to the numeric type if we want to do sorting or summing.

This can fix #3080, but walks in the wrong way for FieldRefactoring.

[pipern]

Add validation/use of numeric (custom) fields

[Remy Blank]

Looks very interesting, thanks! I'm not sure we will manage to get this into 0.13, as we already have the time fields to be integrated there. So I'm scheduling for 0.14 for now.

[Christian Boos]

Looks fine, but as you don't seem to actually use or test for datatype == 'string', I wonder if we couldn't just leave that out of the picture and assume that if datatype is not set or empty, it's a textual field.

[pipern]

Replying to cboos:

Looks fine, but as you don't seem to actually use or test for datatype == 'string', I wonder if we couldn't just leave that out of the picture and assume that if datatype is not set or empty, it's a textual field.

It's true that 'string' has nothing special happening to it. It's there mostly as documentation I suppose.

[Ryan J Ollos]

#11132 closed as a duplicate.

[Jun Omae]

Non-bitsized.

[Jun Omae]

The proposed patch would lead errors with non-numeric string on PostgreSQL.

template1=# SELECT CAST('42' AS INTEGER);
 int4
------
   42
(1 row)

template1=# SELECT CAST('abc' AS INTEGER);
ERROR:  invalid input syntax for integer: "abc"
LINE 1: SELECT CAST('abc' AS INTEGER);
                    ^
template1=# SELECT CAST('42abc' AS INTEGER);
ERROR:  invalid input syntax for integer: "42abc"
LINE 1: SELECT CAST('42abc' AS INTEGER);
                    ^

[Ryan J Ollos]

#8812 closed as a duplicate.

[Ryan J Ollos]

Milestone renamed

[Ryan J Ollos]

Milestone renamed