Edgewall Software

Opened 12 years ago

Last modified 5 years ago

#9730 new enhancement

Allow adding comments to source in browser

Reported by: michaeljt Owned by:
Priority: normal Milestone: unscheduled
Component: version control/browser Version:
Severity: normal Keywords: comment edit
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


This is something I have had in my mind for a while. Given that many people are likely to use the trac browser to study the source of a piece of software they are not fully familiar with, it would make sense if they were allowed to add comments corresponding to that source as they understood how it works. I could imagine something on the lines of a matching ticket being created for comments added by users which developers could handle and close (making the user comments disappear again) once they had transferred the comments to the actual code (or decided not to add a given comment). I realise that this is not a trivial enhancement request, although there may be smarter and simpler ways to achieve the same thing.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos <ryano@…>, 12 years ago

It sounds like you are asking for a simple code review tool, and there are plugins (th:tags:codereview) that feature such as these, though in my experience none of them are very good.

comment:2 by michaeljt, 12 years ago

This would be somewhat simpler than a code review tool. Streamlining my thoughts a bit it might look like the following:

  • an icon in front of each line of code to add a comment before it
  • when a user clicks on the icon a text field appears above that line with instructions and a "submit" button
  • the user enters their comment in the field, formatted correctly for the programming language in use and presses "submit"
  • a new ticket is opened in their name with a patch against the source containing the comment as an attachment

Out of interest, how hard would it be to write something like this as a trac plugin (I have never even looked at how trac plugins work)?

comment:3 by Peter Suter, 5 years ago

Keywords: comment edit added

Possible duplicate of:

Changeset commenting
browse source - edit feature?

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.