tracd --base-path matches any string of the same length

[kamil@…]

Say I start tracd with a a script that looks like:

#!/bin/bash
export ENV=/srv/trac-alpha
tracd -r -p 8081 -s --basic-auth=trac-alpha,$ENV/htpasswd,example.com --base-path=trac/ $ENV

Then any 4-character URL works as the base path. For example visiting ​http://example.com:8081/trac/timeline shows the timeline, as does ​http://example.com:8081/1234/timeline or any other 4-character string.

Visiting ​http://example.com:8081/123/timeline gives an error page with "No handler matched request to timeline" and visiting ​http://example.com:8081/123/timeline gives an error page with "No handler matched request to 5/timeline"

[Remy Blank]

Not very elegant indeed. And probably relatively easy to fix. PatchWelcome.

[Thijs Triemstra <lists@…>]

This patch reveals the issue:

trac/web/standalone.py

@@ -65 +65 @@
 
     def __call__(self, environ, start_response):
         path = environ['SCRIPT_NAME'] + environ.get('PATH_INFO', '')
+        real_path = path[:len(self.base_path)]
+        if real_path != self.base_path:
+            print "this shouldn't be possible? real path: %s, base_path: %s" % (real_path, self.base_path)
+            return []
         environ['PATH_INFO'] = path[len(self.base_path):]
         environ['SCRIPT_NAME'] = self.base_path
         return self.application(environ, start_response)

This is the output:

this shouldn't be possible? real path: /1234, base_path: /trac
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 51106)
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/SocketServer.py", line 558, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/local/lib/python2.6/SocketServer.py", line 320, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/local/lib/python2.6/SocketServer.py", line 615, in __init__
    self.handle()
  File "/usr/local/lib/python2.6/BaseHTTPServer.py", line 329, in handle
    self.handle_one_request()
  File "/Users/thijstriemstra/Sites/trac-0.12-stable/trac/web/wsgi.py", line 189, in handle_one_request
    gateway.run(self.server.application)
  File "/Users/thijstriemstra/Sites/trac-0.12-stable/trac/web/wsgi.py", line 100, in run
    self._write('')
  File "/Users/thijstriemstra/Sites/trac-0.12-stable/trac/web/wsgi.py", line 207, in _write
    assert self.headers_set, 'Response not started'
AssertionError: Response not started

So instead of the AssertionError it should return a 404. Not sure how to do this yet.