Control the default wiki page through trac.ini

[a-h]

Hello,

Here's a way to change the default wiki page:

web_ui.

@@ -107 +107 @@
 
     def process_request(self, req):
         action = req.args.get('action', 'view')
-        pagename = req.args.get('page', 'WikiStart')
+        pagename = req.args.get('page',
+                                self.env.config['wiki'].get('default_page')
+                                    or 'WikiStart')
         version = req.args.get('version')
         old_version = req.args.get('old_version')

[Remy Blank]

Unfortunately, it's not quite that simple. The name "WikiStart" is hard-coded at various locations, e.g. for re-directing after deleting a page. I think there was even a more complete patch for this, but my search-fu seems to be severely lacking lately. I thought it was part of #1106, but no luck.

[Peter Suter]

Possible duplicate of #5319.

[Peter Suter]

And #10595 which has an attached patch​.

[Ryan J Ollos]

Closed #10595 as a duplicate. This ticket, if implemented, can also make customizable the location pointed to be TitleIndex.

[Ryan J Ollos]

Since this is probably rarely customized, we could just extract variables like we did for default_tracker (comment:1:ticket:10898): [98dd2d30/rjollos.git].

# -*- coding: utf-8 -*-

from trac.wiki import web_ui


web_ui.WikiModule.START_PAGE = 'Trac/WikiStart'
web_ui.WikiModule.TITLE_INDEX = 'Trac/TitleIndex'

[Ryan J Ollos]

Committed to trunk in r15818.

[Jun Omae]

At least, WikiStart is still remained at two locations:

mirror/trunk:trac/wiki/api.py:        pagename = pagename.rstrip('/') or 'WikiStart'
mirror/trunk:trac/wiki/templates/wiki_page_path.html:<a class="pathentry first" title="${_('View WikiStart')}"

$ git grep -w WikiStart mirror/trunk -- '*.py' '*.html' | egrep -v '/test(\.py|s/)'
mirror/trunk:contrib/checkwiki.py:            if name in ('SandBox', 'TitleIndex', 'WikiStart'):
mirror/trunk:contrib/help_guide_version_notice.py:                               'TitleIndex, SandBox, WikiStart',
mirror/trunk:trac/mimeview/api.py:        >>> context = RenderingContext('wiki', 'WikiStart')
mirror/trunk:trac/perm.py:        'WIKI_MODIFY' in perm('wiki', 'WikiStart')
mirror/trunk:trac/perm.py:        perm('wiki', 'WikiStart').require('WIKI_MODIFY')
mirror/trunk:trac/resource.py:        >>> main = Resource('wiki', 'WikiStart')
mirror/trunk:trac/resource.py:        "<Resource u'wiki:WikiStart'>"
mirror/trunk:trac/resource.py:        "<Resource u'wiki:WikiStart@3'>"
mirror/trunk:trac/resource.py:        "<Resource u'wiki:WikiStart@0'>"
mirror/trunk:trac/web/chrome.py:        The following example renames the link to WikiStart to //Home//,
mirror/trunk:trac/wiki/admin.py:                        ignore=['WikiStart'], create_only=['InterMapTxt'])
mirror/trunk:trac/wiki/api.py:        pagename = pagename.rstrip('/') or 'WikiStart'
mirror/trunk:trac/wiki/api.py:        >>> main = Resource('wiki', 'WikiStart')
mirror/trunk:trac/wiki/api.py:        'WikiStart'
mirror/trunk:trac/wiki/api.py:        'WikiStart'
mirror/trunk:trac/wiki/api.py:        'WikiStart'
mirror/trunk:trac/wiki/api.py:        >>> resource_exists(env, Resource('wiki', 'WikiStart'))
mirror/trunk:trac/wiki/api.py:        >>> main = WikiPage(env, 'WikiStart')
mirror/trunk:trac/wiki/templates/wiki_page_path.html:<a class="pathentry first" title="${_('View WikiStart')}"
mirror/trunk:trac/wiki/web_ui.py:    START_PAGE = 'WikiStart'
mirror/trunk:tracopt/perm/authz_policy.py:       Example: Match the WikiStart page::
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart*]
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart@*]
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart]
mirror/trunk:tracopt/perm/authz_policy.py:       ``wiki:WikiStart@117/attachment/FOO.JPG@*`` on WikiStart::
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart*]
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart@*]
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart@*/attachment/*]
mirror/trunk:tracopt/perm/authz_policy.py:         [wiki:WikiStart@117/attachment/FOO.JPG]
mirror/trunk:tracopt/perm/authz_policy.py:      [wiki:WikiStart@*]

[Ryan J Ollos]

Additional changes in [6c805489/rjollos.git].

[Jun Omae]

IMO, I'd like to avoid to set values to class attribute in instance method __init__. How about using property() like this?

trac/wiki/web_ui.py

@@ -62 +62 @@
         """Default height of the textarea on the wiki edit page.
         (//Since 1.1.5//)""")
 
-    START_PAGE = None
-    TITLE_INDEX_PAGE = None
+    START_PAGE = property(lambda self: WikiSystem.START_PAGE)
+    TITLE_INDEX_PAGE = property(lambda self: WikiSystem.TITLE_INDEX_PAGE)
     PAGE_TEMPLATES_PREFIX = 'PageTemplates/'
     DEFAULT_PAGE_TEMPLATE = 'DefaultPage'
 
-    def __init__(self):
-        self.__class__.START_PAGE = WikiSystem.START_PAGE
-        self.__class__.TITLE_INDEX_PAGE = WikiSystem.TITLE_INDEX_PAGE
-
     # IContentConverter methods
 
     def get_supported_conversions(self):

[Ryan J Ollos]

That looks good. Committed to trunk in r15822.

Revised plugin is:

# -*- coding: utf-8 -*-

from trac.wiki import api


api.WikiSystem.START_PAGE = 'Trac/WikiStart'
api.WikiSystem.TITLE_INDEX_PAGE = 'Trac/TitleIndex'

[Ryan J Ollos]

Related, there are no permission checks done before adding the contextual navigation items: tags/trac-1.2.1/trac/wiki/web_ui.py@:728,729#L726​. Fixed on 1.2-stable in r15851, merged to trunk in r15852.