Edgewall Software

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9386 closed defect (fixed)

[PATCH] Wrong "Today" marker in timeline page

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 0.12
Component: timeline Version: 0.12dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:


I accessed the timeline page in t.e.o at 5/27 16:45 UTC. I have selected Asia/Tokyo timezone (GMT +0900) in preferences page.

5/27 16:45 UTC is 5/28 01:45 in Asia/Tokyo.

"Today" marker is shown at "5/27/10". If system timezone is different than user timezone, the problem occurs.

  • trac/timeline/web_ui.py

    131131        data = {'fromdate': fromdate, 'daysback': daysback,
    132132                'authors': authors,
    133                 'today': format_date(today),
    134                 'yesterday': format_date(today - timedelta(days=1)),
     133                'today': format_date(today, tzinfo=req.tz),
     134                'yesterday': format_date(today - timedelta(days=1),
     135                                         tzinfo=req.tz),
    135136                'precisedate': precisedate, 'precision': precision,
    136137                'events': [], 'filters': [],
    137138                'abbreviated_messages': self.abbreviated_messages}

Attachments (2)

timeline.png (23.2 KB ) - added by Jun Omae 9 years ago.
prefs-timezone.png (13.0 KB ) - added by Jun Omae 9 years ago.

Download all attachments as: .zip

Change History (4)

by Jun Omae, 9 years ago

Attachment: timeline.png added

by Jun Omae, 9 years ago

Attachment: prefs-timezone.png added

comment:1 by Remy Blank, 9 years ago

Resolution: fixed
Status: newclosed

The same patch was already suggested in #8664, and another solution was suggested there, which unfortunately doesn't work. So I applied this patch in [9799] anyway, until a correct fix is found.

comment:2 by Remy Blank, 9 years ago

Owner: set to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.