Modify ↓
#9386 closed defect (fixed)
[PATCH] Wrong "Today" marker in timeline page
Reported by: | Jun Omae | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 0.12 |
Component: | timeline | Version: | 0.12dev |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
I accessed the timeline page in t.e.o at 5/27 16:45 UTC.
I have selected Asia/Tokyo
timezone (GMT +0900) in preferences page.
5/27 16:45 UTC is 5/28 01:45 in Asia/Tokyo
.
"Today" marker is shown at "5/27/10". If system timezone is different than user timezone, the problem occurs.
-
trac/timeline/web_ui.py
130 130 131 131 data = {'fromdate': fromdate, 'daysback': daysback, 132 132 'authors': authors, 133 'today': format_date(today), 134 'yesterday': format_date(today - timedelta(days=1)), 133 'today': format_date(today, tzinfo=req.tz), 134 'yesterday': format_date(today - timedelta(days=1), 135 tzinfo=req.tz), 135 136 'precisedate': precisedate, 'precision': precision, 136 137 'events': [], 'filters': [], 137 138 'abbreviated_messages': self.abbreviated_messages}
Attachments (2)
Change History (4)
by , 14 years ago
Attachment: | timeline.png added |
---|
by , 14 years ago
Attachment: | prefs-timezone.png added |
---|
comment:1 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 14 years ago
Owner: | set to |
---|
Note:
See TracTickets
for help on using tickets.
The same patch was already suggested in #8664, and another solution was suggested there, which unfortunately doesn't work. So I applied this patch in [9799] anyway, until a correct fix is found.