Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#9325 closed defect (fixed)

Table of ticket notification mails is wrong with long label of custom fields

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 0.12
Component: notification Version: 0.12dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When custom fields have long label, it breaks the table of ticket notification mails. Trac 0.11.x don't have the issue.

Attached long-label-r9663.diff for the issue.

in conf/trac.ini;

[ticket-custom]
long_name_1 = text
long_name_1.format = plain
long_name_1.label = 1 long long long label
long_name_1.order = 0
long_name_2 = text
long_name_2.format = plain
long_name_2.label = 2 long long long label
long_name_2.order = 1

I have got such a mail:

--------------------------+-------------------------------------------------
   Reporter:  anonymous   |         Owner:  somebody  
       Type:  defect      |        Status:  new       
   Priority:  blocker     |     Milestone:  milestone1
  Component:  component1  |       Version:  1.0       
   Severity:  new         |    Resolution:            
   Keywords:              |   1 long long long label:            
2 long long long label:              |  
--------------------------+-------------------------------------------------

After applied the patch:

-------------------------------------+--------------------------------------
              Reporter:  anonymous   |                    Owner:  somebody  
                  Type:  defect      |                   Status:  new       
              Priority:  blocker     |                Milestone:  milestone1
             Component:  component1  |                  Version:  1.0       
              Severity:  new         |               Resolution:            
              Keywords:              |   1 long long long label:            
2 long long long label:              |  
-------------------------------------+--------------------------------------

Attachments (1)

long-label-r9663.diff (1.1 KB ) - added by Jun Omae 14 years ago.

Download all attachments as: .zip

Change History (8)

by Jun Omae, 14 years ago

Attachment: long-label-r9663.diff added

comment:1 by Christian Boos, 14 years ago

It would be interesting to know what caused this regression.

comment:2 by Remy Blank, 14 years ago

I would have guessed ticket label internationalization, i.e. [8523], but that shouldn't have anything to do with custom fields, should it?

in reply to:  2 comment:3 by Jun Omae, 14 years ago

Replying to rblank:

I would have guessed ticket label internationalization, i.e. [8523], but that shouldn't have anything to do with custom fields, should it?

In [8969,9388], the notification mail isn't translated.

I expect that the labels of custom field are not translated and texts of <field-name>.label are used without translations.

I try long_name_1.label = Summary, "Summary" is translated. It's bad….

[ticket-custom]
long_name_1 = text
long_name_1.format = plain
long_name_1.label = Summary
long_name_1.order = 0

comment:4 by Jun Omae, 14 years ago

What I mean to say is "the long labels of custom fields breaks table cell width" like #4717.

comment:5 by Remy Blank, 14 years ago

Resolution: fixed
Status: newclosed

Patch applied in [9682], thanks.

About comment:3, do you mean that the labels of custom fields are translated in the ticket web pages, or in the notification e-mail? The latter should not be the case. The former is due to the label being a string that is present in the catalog. I agree that it's currently not consistent, but I'd rather leave it at that until we allow translating the custom ticket field labels (for which we don't have a ticket yet).

comment:6 by Remy Blank, 14 years ago

Owner: set to Jun Omae

in reply to:  5 comment:7 by Jun Omae, 14 years ago

Replying to rblank:

Patch applied in [9682], thanks.

Thanks!

About comment:3, do you mean that the labels of custom fields are translated in the ticket web pages, or in the notification e-mail? The latter should not be the case.

In the ticket web pages, the labels of custom fields are translated. In the notification mails, not translated.

The former is due to the label being a string that is present in the catalog. I agree that it's currently not consistent, but I'd rather leave it at that until we allow translating the custom ticket field labels (for which we don't have a ticket yet).

Ok.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.