#9325 closed defect (fixed)
Table of ticket notification mails is wrong with long label of custom fields
Reported by: | Jun Omae | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 0.12 |
Component: | notification | Version: | 0.12dev |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
When custom fields have long label, it breaks the table of ticket notification mails. Trac 0.11.x don't have the issue.
Attached long-label-r9663.diff for the issue.
in conf/trac.ini;
[ticket-custom] long_name_1 = text long_name_1.format = plain long_name_1.label = 1 long long long label long_name_1.order = 0 long_name_2 = text long_name_2.format = plain long_name_2.label = 2 long long long label long_name_2.order = 1
I have got such a mail:
--------------------------+------------------------------------------------- Reporter: anonymous | Owner: somebody Type: defect | Status: new Priority: blocker | Milestone: milestone1 Component: component1 | Version: 1.0 Severity: new | Resolution: Keywords: | 1 long long long label: 2 long long long label: | --------------------------+-------------------------------------------------
After applied the patch:
-------------------------------------+-------------------------------------- Reporter: anonymous | Owner: somebody Type: defect | Status: new Priority: blocker | Milestone: milestone1 Component: component1 | Version: 1.0 Severity: new | Resolution: Keywords: | 1 long long long label: 2 long long long label: | -------------------------------------+--------------------------------------
Attachments (1)
Change History (8)
by , 15 years ago
Attachment: | long-label-r9663.diff added |
---|
comment:1 by , 15 years ago
follow-up: 3 comment:2 by , 15 years ago
I would have guessed ticket label internationalization, i.e. [8523], but that shouldn't have anything to do with custom fields, should it?
comment:3 by , 15 years ago
Replying to rblank:
I would have guessed ticket label internationalization, i.e. [8523], but that shouldn't have anything to do with custom fields, should it?
In [8969,9388], the notification mail isn't translated.
I expect that the labels of custom field are not translated and texts of <field-name>.label
are used without translations.
I try long_name_1.label = Summary
, "Summary" is translated. It's bad….
[ticket-custom] long_name_1 = text long_name_1.format = plain long_name_1.label = Summary long_name_1.order = 0
comment:4 by , 15 years ago
What I mean to say is "the long labels of custom fields breaks table cell width" like #4717.
follow-up: 7 comment:5 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch applied in [9682], thanks.
About comment:3, do you mean that the labels of custom fields are translated in the ticket web pages, or in the notification e-mail? The latter should not be the case. The former is due to the label being a string that is present in the catalog. I agree that it's currently not consistent, but I'd rather leave it at that until we allow translating the custom ticket field labels (for which we don't have a ticket yet).
comment:6 by , 15 years ago
Owner: | set to |
---|
comment:7 by , 15 years ago
Replying to rblank:
Patch applied in [9682], thanks.
Thanks!
About comment:3, do you mean that the labels of custom fields are translated in the ticket web pages, or in the notification e-mail? The latter should not be the case.
In the ticket web pages, the labels of custom fields are translated. In the notification mails, not translated.
The former is due to the label being a string that is present in the catalog. I agree that it's currently not consistent, but I'd rather leave it at that until we allow translating the custom ticket field labels (for which we don't have a ticket yet).
Ok.
It would be interesting to know what caused this regression.