"function" argument of i18n:msg is missing in the extracted message

[Jun Omae]

"function" argument of i18n:msg is specified in error.html​, howerver, the "function" argument is missing in the extracted message.

source:trunk/trac/locale/messages.pot@9605:1876-1877#L1876​

#: trac/templates/error.html:167
#, python-format
msgid ""
"File \"%(file)s\",\n"
"                        line [1:%(line)s], in"
msgstr ""

trac/templates/error.html

@@ -163 +163 @@
                   Most recent call last:
                   <ul py:if="frames" style="display: none">
                     <li class="frame" py:for="idx, frame in enumerate(frames)">
-                      <a href="#frame${idx}" id="frame${idx}">
-                        <span class="file" i18n:msg="file, line, function">File "${frame.filename}",
-                        line <b>${frame.lineno + 1}</b>, in</span>
+                      <a href="#frame${idx}" id="frame${idx}" i18n:msg="file, line, function">
+                        <span class="file">File "${frame.filename}", line <b>${frame.lineno + 1}</b>, in</span>
                         <var>${frame.function}</var>
                       </a>
                       <div py:if="frame.line" class="source" style="display: none">

[Christian Boos]

Ah yes, wrong nesting. Well spotted!

[Christian Boos]

It should have been a simple matter of doing:

trac/templates/error.html

@@ -163 +163 @@
                   Most recent call last:
                   <ul py:if="frames" style="display: none">
                     <li class="frame" py:for="idx, frame in enumerate(frames)">
-                      <a href="#frame${idx}" id="frame${idx}">
-                        <span class="file" i18n:msg="file, line, function">File "${frame.filename}",
+                      <a href="#frame${idx}" id="frame${idx}"><i18n:msg params="file, line, function">
+                        <span class="file">File "${frame.filename}",
                         line <b>${frame.lineno + 1}</b>, in</span>
-                        <var>${frame.function}</var>
+                        <var>${frame.function}</var></i18n:msg>
                       </a>
                       <div py:if="frame.line" class="source" style="display: none">
                         <h3>Code fragment:</h3>

Then a new extraction:

#: trac/templates/error.html:166
#, python-format
msgid ""
"[1:File \"%(file)s\",\n"
"                        line [2:%(line)s], in]\n"
"                        [3:%(function)s]"
msgstr ""

And update:

#: trac/templates/error.html:166
#, python-format
msgid ""
"[1:File \"%(file)s\",\n"
"                        line [2:%(line)s], in]\n"
"                        [3:%(function)s]"
msgstr ""
"[1:Fichier « %(file)s »,\n"
"                        ligne [2:%(line)s], dans]\n"
"                        [3:%(function)s]"

Unfortunately, that message wasn't translated. Likely a Genshi 0.6 bug, as other test changes I made to the messages.po file did show correctly while testing that page.

Attaching the whole diff​ for easier testing and confirmation of the issue.

[Christian Boos]

the change to error.html + make extraction update-fr + translation of that message in french

[Christian Boos]

The problem was very similar to #9308 and the same fix was applied in r9631, hence credits go to Jun ;-)

Extraction + french updates done in r9632 and r9633.

In addition, r9632 will be very interesting for checking what Transifex does when the count of messages in the messages.pot doesn't change, in relation with #Tx583.

Note that translators should be very careful with this update, in order to avoid issues like #9171.

(I just noticed I already had closed that ticket by mistake, so I leave it closed only fixing the owner; thanks again Jun!)