Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#9106 closed defect (fixed)

In SpamFilter, a few over-optimistic assumptions about req.args

Reported by: Christian Boos Owned by:
Priority: normal Milestone: plugin - spam-filter
Component: plugin/spamfilter Version: 0.11-stable
Severity: normal Keywords: verify
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

One for attachments:

2010-01-11 18:51:12,305 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/main.py", line 450, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/main.py", line 206, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/attachment.py", line 398, in process_request
    self._do_save(req, attachment)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/attachment.py", line 554, in _do_save
    upload = req.args['attachment']
KeyError: 'attachment'

and a similar one for the wiki … (need to look in the log again).

And yet another error in SpamFilter, unicode related this time:

2009-12-29 10:37:16,772 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8965-py2.5.egg/trac/web/main.py", line 450, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8965-py2.5.egg/trac/web/main.py", line 206, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8965-py2.5.egg/trac/attachment.py", line 398, in process_request
    self._do_save(req, attachment)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8965-py2.5.egg/trac/attachment.py", line 589, in _do_save
    attachment):
  File "build/bdist.linux-x86_64/egg/tracspamfilter/adapters.py", line 135, in validate_attachment
    FilterSystem(self.env).test(req, author, changes)
  File "build/bdist.linux-x86_64/egg/tracspamfilter/api.py", line 104, in test
    content = self._combine_changes(changes)
  File "build/bdist.linux-x86_64/egg/tracspamfilter/api.py", line 239, in _combine_changes
    return sep.join(fields)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 33: ordinal not in range(128)

All seen in the logs of some egdewall.org Trac instances.

Attachments (0)

Change History (3)

comment:1 by Christian Boos, 14 years ago

Keywords: verify added

Eventually fixed by r9462, need to check the log in a few days.

comment:2 by anonymous, 14 years ago

Should be applied to spam-filter-captcha in 0.12 as well.

comment:3 by Dirk Stöcker, 14 years ago

Resolution: fixed
Status: newclosed

In r9874 also for 0.12.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.