race condition in session code

[Christian Boos]

Seeing an assert triggered is not good…

2010-01-18 21:57:18,675 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/main.py", line 450, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/main.py", line 206, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/prefs/web_ui.py", line 73, in process_request
    template, data = chosen_provider.render_preference_panel(req, panel_id)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/prefs/web_ui.py", line 91, in render_preference_panel
    self._do_load(req)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/prefs/web_ui.py", line 133, in _do_load
    req.session.get_session(oldsid)
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/session.py", line 182, in get_session
    self.bake_cookie()
  File "/usr/local/virtualenv-0.11/lib/python2.5/site-packages/Trac-0.11.7stable_r8997-py2.5.egg/trac/web/session.py", line 163, in bake_cookie
    assert self.sid, 'Session ID not set'
AssertionError: Session ID not set

Seen with Trac 0.11.7rc1 (point 3. in ticket:9077#comment4).

No idea yet about the fix, so scheduling for some later bugfix release.

[Christian Boos]

Remy, any idea about this one? … now that you master the session code ;-)

[Remy Blank]

Yes, this happened when you tried to load a session with an empty name in the "Advanced" preference panel (see comment:2:ticket:9658 and comment:8:ticket:9658). This should be fixed with the last hunk of [10259].