trac-admin resync crashes for TracMercurial because of extsetup

[antonxx@…]

I use trac-admin (0.11.6) and do a resync of my hg repositories, and trac-admin crashes.

In the TracMercurial plugin the code in backend.py is:

if extsetup:
   extsetup()

which is wrong.

Reason: extsetup needs a parameter

I changed it to, the following:

if extsetup:
   extsetup(self.ui) #bugfix

Now trac-admin does not crash.. but I am not sure if my workaround is correct

See:

​http://trac.edgewall.org/browser/sandbox/mercurial-plugin-0.11/tracext/hg/backend.py?rev=8907#L188

[Christian Boos]

Could you please confirm the following fix?

tracext/hg/backend.py

@@ -185 +185 @@
                 # setup extensions
                 extsetup = getattr(module, 'extsetup', None)
                 if extsetup:
-                    extsetup()
+                    if arity(extsetup) == 1:
+                        extsetup(self.ui)
+                    else:
+                        extsetup()
 
     def get_supported_types(self):
         """Support for `repository_type = hg`"""

[antonxx@…]

OK thanks,

it does not crash anymore.

I leave it up to you to close this ticket as soon as you have patched the sources ;-)

Anton

[Christian Boos]

Thanks for testing, committed in r8963 and r8964.