View Tickets report list is empty since [8717]

[tjb@…]

Since updating to [8717], any trac projects which use the Timing and Estimation plugin have showed no reports when 'View Tickets' was selected.

This only occurs when the highest report number is from the Timing and Estimation reports.

A workaround is to create a new report numbered higher than the Timing and Estimation reports, then the whole list re-appears.

[anonymous]

I realise that the problem may lie in using the TimingandEstimation plugin with trac-0.12, but it has worked well until now.

No message is recorded in the trac.log, at INFO level.

[Christian Boos]

Well, not knowing what the ​TH:TimingAndEstimationPlugin does exactly, it's hard to do anything about this, so I'd suggest that you contact the plugin maintainer, which will then either:

• point us to what needs to be fixed on the Trac side; if it's a simple change we can do for backward compatibility, we'll do it
• create a 0.12 branch for the plugin otherwise

In the first situation, don't hesitate to reopen.

[Remy Blank]

I had a look at the ​TH:TimingAndEstimationPlugin, and it has a Genshi filter hiding reports from the plugin that seems to get confused by the change of the template name.

Something like the following should do and remain backward-compatible with 0.11 (completely untested):

timingandestimationplugin/tande_filters.py

@@ -82 +82 @@
     implements(ITemplateStreamFilter)
 
     def match_stream(self, req, method, filename, stream, data):
-        return filename == 'report_view.html'
+        return filename in ('report_view.html', 'report_list.html')
 
     def filter_stream(self, req, method, filename, stream, data):
         return stream | Transformer(

I don't know how it explains the symptoms you described, but it's worth a shot.

[tjb@…]

Thanks cboos and rblank.

I will try the suggested patch, and see if it improves things.

I symptom that I hadn't noticed before is that the reports which should be hidden are not hidden when I apply my workaround. I will raise this with the TimingandEstimation project too…

[anonymous]

Replying to tjb@…:

Thanks cboos and rblank.

I will try the suggested patch, and see if it improves things.

I symptom that I hadn't noticed before is that the reports which should be hidden are not hidden when I apply my workaround. I will raise this with the TimingandEstimation project too…

The suggested patch is definitely necessary, but seems to be insufficient. It seems that Genshi changed the way it handles applying Transformers. Previously it would call the transform once per tag selected, but now seems to call the transformer, once with a contiguous stream of events. Without the separation between tags my code has bugs in it.

This ticket is definitely invalid, as the bug lies with ​TH:TimingAndEstimationPlugin (or perhaps with Genshi, though as best as I have currently worked out, Genshi's behaviour is correct)

Russ Tyndall

TH user bobbysmith007

Author of ​TH:TimingAndEstimationPlugin