No version "0" for Wiki page "FooPage"

[g.burgstaller@…]

How to reproduce:

1. Search for a non-existing page, i.e. "FooPage" and click button "Create this page."

2. From another browser window or another computer (same or different user) do the same, edit the page and click "Submit changes".

3. Now, in the first window, whichever button you choose, you will get a Trac Error No version "0" for Wiki page "FooPage".

[Remy Blank]

Not really of "major" severity, but still a bug. Thanks for the report.

[Carsten Klein <carsten.klein@…>]

I think that this should rather present the user with a conflict page or at least a conflict notification.

[Carsten Klein <carsten.klein@…>]

See the attached patch for a fix to this defect.

The patch will eventually cause the web_ui to display the usual in-conflict notification message and allows the user to merge in his or her changes.

It basically just removes the special case prior to entering the action handling logic.

[Christian Boos]

The patch would effectively fix the issue in a nice way, but the code removed had some usefulness, see r4369, r4377.

The following is a better fix:

trac/wiki/web_ui.py

@@ -120 +120 @@
         req.perm(page.resource).require('WIKI_VIEW')
         req.perm(versioned_page.resource).require('WIKI_VIEW')
 
-        if version and versioned_page.version == 0 and \
-               page.version != 0:
+        if version and versioned_page.version != int(version):
             raise TracError(_('No version "%(num)s" for Wiki page "%(name)s"',
                               num=version, name=page.name))

While testing I discovered another issue in the current code, by which the conflict detection code could be by-passed… Not good.

[Carsten Klein <carsten.klein@…>]

Thanks for fixing this.

I wonder if it would not be better to issue a HTTP404 exception instead of simply a TracError exception?

[Christian Boos]

Could be a ResourceNotFound error, yes.

[Christian Boos]

Fixed in r9369. The problem mentioned in comment:6 which involves the template argument on concurrent page creation attempts will have to be fixed next before closing.

[AdrianFritz]

#7276 looks like related

[Christian Boos]

Unassigning, as this is not actively worked on.

[Ryan J Ollos]

Replying to cboos:

Fixed in r9369. The problem mentioned in comment:6 which involves the template argument on concurrent page creation attempts will have to be fixed next before closing.

I haven't been able to reproduce any issues with the template argument. Do you recall what the issue is?

[Christian Boos]

Replying to rjollos:

Replying to cboos:

Fixed in r9369. The problem mentioned in comment:6 which involves the template argument on concurrent page creation attempts will have to be fixed next before closing.

I haven't been able to reproduce any issues with the template argument. Do you recall what the issue is?

I always thought that there was still a problem with concurrent wiki page creation, but I can't trigger it anymore either and I can't see in the code what could have been the problem (especially how the use of template could lead to by-pass the version check). So let's close this as if r9369 would have been the last changeset for this ticket.

[Christian Boos]

Replying to cboos:

(especially how the use of template could lead to by-pass the version check)

Unless I had at that time already hit the same issue that is described in ticket:7276#comment:6…