Edgewall Software
Modify

Opened 8 years ago

Last modified 9 months ago

#8700 reopened defect

patch for trac-svn-post-commit-hook.cmd

Reported by: federico.briata@… Owned by:
Priority: normal Milestone: next-stable-1.2.x
Component: version control Version: devel
Severity: normal Keywords: patch multirepos windows
Cc: Christian Boos
Release Notes:
API Changes:

Description

With last Multirepos branch, you need to specify just the repository's name instead full repository path; otherwise trac-admin will not resync.

The patch in attach correct this problem and clarifies the usage of batch files.

The batch file is tested on Win Xp.

Thanks you. Federico [at] Briata [dot] Org

Attachments (2)

argument-fix_trac-svn-post-commit-hook_cmd.patch (1.4 KB ) - added by federico.briata@… 8 years ago.
argument-fix_trac-svn-post-commit-hook_cmd.2.patch (1.4 KB ) - added by federico.briata@… 8 years ago.
added @ECHO OFF for post-commit.bat

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by federico.briata@…

comment:1 Changed 8 years ago by federico.briata@…

Resolution: fixed
Status: newclosed

I forgot to say that post-commit.bat is extracting the Repository Name (last Folder) from the full path provided by Subversion after a commit.

comment:2 Changed 8 years ago by mike.sherov@…

Resolution: fixed
Status: closedreopened

shouldn't this remain as not closed until it's integrated into the source code?

Changed 8 years ago by federico.briata@…

added @ECHO OFF for post-commit.bat

comment:3 Changed 8 years ago by federico.briata@…

can be convegnent modify the step 10 of /wiki/MultipleRepositorySupport to point to this patch?

In attach a new patch with @ECHO OFF for post-commit.bat, this one replace the 1st one.

comment:4 Changed 8 years ago by Christian Boos

Component: generalversion control
Keywords: windows added; xp removed
Milestone: 0.120.12-multirepos

Thanks for the patches, I'll look at them.

comment:5 in reply to:  description Changed 8 years ago by Christian Boos

Milestone: 0.12-multirepos0.12

Replying to federico.briata@…:

With last Multirepos branch, you need to specify just the repository's name instead full repository path; otherwise trac-admin will not resync.

This is no longer true, the full path can be given again.

I'll eventually finish the trunk/contrib/trac-svn-post-commit-hook.cmdand then rename it to trunk/contrib/trac-svn-hook.cmd), to mimic trunk/contrib/trac-svn-hook, but this is not high priority, given a simple call to trac-admin can be directly added to the post-commit.bat and post-revprop-change.bat hooks (see 0.12/TracRepositoryAdmin).

comment:6 Changed 7 years ago by Christian Boos

Milestone: 0.12next-minor-0.12.x

Not high priority, as explained above.

comment:8 Changed 3 years ago by Ryan J Ollos

Milestone: next-minor-0.12.xnext-stable-1.0.x

Moving forward since it doesn't seem necessary to fix this for 0.12-stable. Please comment if you feel otherwise.

comment:9 Changed 2 years ago by Ryan J Ollos

comment:10 Changed 20 months ago by figaro

Keywords: patch added

comment:11 Changed 9 months ago by Ryan J Ollos

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences .

 
Note: See TracTickets for help on using tickets.