Edgewall Software
Modify

Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#8650 closed enhancement (fixed)

Wiki does not render/obfuscate explicit e-mail links user friendly

Reported by: Mitar Owned by: Christian Boos
Priority: normal Milestone: 0.11.6
Component: wiki system Version: 0.11.4
Severity: normal Keywords:
Cc: mmitar@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Wiki does not render/obfuscate explicit (mailto) e-mail links with label user friendly. The problem is that if we have show_email_addresses set to false false and users do not have EMAIL_VIEW privilege currently e-mail link is completely hidden for them and only label is shown. They do not know that there should be any link for sending e-mail or that they have to register to see it. They do not get any visual or other feedback. It renders as normal text what is especially problematic for e-mail links embedded in other text.

I would propose a preference not to obfuscate explicit e-mail links in any way as if user enters an e-mail address into a wiki he/she should now that it will be visible to all. And that this is probably what he/she wants.

Is it possible to extend e-mail rendering with a plugin? So that some more complicated rendering/obfuscation (JavaScript based, captcha based…) would be possible for e-mail links on wiki? If not it would be best to add that.

Attachments (1)

t8650-never_obfuscate_mailto-r8857.diff (4.9 KB ) - added by Christian Boos 14 years ago.
Add a configuration setting for never obfuscating mailto: links.

Download all attachments as: .zip

Change History (9)

comment:1 by Christian Boos, 14 years ago

Resolution: wontfix
Status: newclosed

Well, it's always possible to spell out an e-mail address such that it won't get recognized by the regexp, e.g. cboos @ neuf.fr …

Better have consistent behavior, #153 was about to obfuscate all e-mails, which is a safe default. Let's not introduce exceptions.

comment:2 by mmitar@…, 14 years ago

It is not about spelling out but about making links. So [mailto:mail@example.com] for example.

Would it be possible to at least add an extension point so that plugin could handle this? So that it would be possible to add reCaptcha or some other way of fighting spambots? It could be also generic to be able to hoop to a display of some link prefix. In this case mailto prefix?

comment:3 by Christian Boos, 14 years ago

See IWikiSyntaxProvider. You can register a link resolver for mailto:, and this will take precedence over the default behavior.

comment:4 by Mitar, 14 years ago

Thanks.

comment:5 by Christian Boos, 14 years ago

Milestone: 0.11.6
Resolution: wontfix
Status: closedreopened

Michael Renzmann wrote on th-users:

  1. [mailto:...] links are not shown to anonymous users, since they

lack the EMAIL_VIEW permission. […]

(me) This was discussed yesterday in ticket #8650. Please tell me if you think a setting for /not/ obfuscating explicit mailto: links would be a good idea, then I'll implement it. Otherwise, like I suggested there, it's a simple matter of doing a link resolver.

I vote for having such a setting, which should default to the current behaviour however.

If the change makes sense for track-hacks, I think we should add that last minute feature (quite low risk actually).

by Christian Boos, 14 years ago

Add a configuration setting for never obfuscating mailto: links.

comment:6 by Christian Boos, 14 years ago

Resolution: fixed
Status: reopenedclosed

Remy acked the change.

Committed in r8863.

comment:7 by Christian Boos, 14 years ago

Owner: set to Christian Boos
Type: defectenhancement

comment:8 by Mitar, 14 years ago

Great! Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.