Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#863 closed defect (fixed)

wrong address in email links

Reported by: paul@… Owned by: utopiste
Priority: high Milestone: 0.9
Component: ticket system Version: 0.7.1
Severity: major Keywords:
Cc: fharvey@… Branch:
Release Notes:
API Changes:

Description

I think the addresses in notification emails shouldn't be based off of the base url the http request came in on, but rather a value from the trac.ini file

i have an apache server, which reverse-proxies requests to tracd daemons each running either single or multiple projects, this allows for much more complex scenarios on a limited ip space without special non-80 ports, especially in hosting scenarios

what happens is the emails contain links to http://localhost:5001, which is useless off the server

i'm sure theres scenarios where you may want to keep the current behavior, so maybe it should be configurable, although in general i think a configuration value would allow for the most flexibility in setup

Attachments (0)

Change History (6)

comment:1 by Jonas Borgström, 15 years ago

Priority: normalhigh
Severity: normalmajor

comment:2 by Jonas Borgström, 15 years ago

Milestone: 0.9

comment:3 by utopiste, 15 years ago

Owner: changed from Jonas Borgström to utopiste
Status: newassigned

I have added a base_url config in trac.ini (currently used by RSS stream feature), i will add support for base_url config inside the Notify Class.

comment:4 by Christopher Lenz, 15 years ago

Component: generalticket system

comment:5 by utopiste, 15 years ago

Cc: fharvey@… added

test notify feature

comment:6 by Christopher Lenz, 15 years ago

Resolution: fixed
Status: assignedclosed

I believe this should work correctly now after [1298].

Firstly, trac should now correctly pick-up the correct host if the proxy adds a X-Forwarded-For header. If that doesn't work for some reason, you can specify the absolute base URL with the base_url option in the [trac] section of TracIni. The latter will always take precedence.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain utopiste.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from utopiste to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.