Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8619 closed enhancement (fixed)

Improve readability of ConfigurableTicketWorkflow by splitting up long methods

Reported by: Felix Schwarz <felix.schwarz@…> Owned by: Felix Schwarz <felix.schwarz@…>
Priority: lowest Milestone: 0.12
Component: ticket system Version: 0.12dev
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I found some code in the ConfigurableTicketWorkflow very hard to read so I tried to split out some code into separate methods.

Attachments (1)

8619_split_long_methods_in_workflow​ (2.6 KB ) - added by Felix Schwarz <felix.schwarz@…> 15 years ago.

Download all attachments as: .zip

Change History (4)

by Felix Schwarz <felix.schwarz@…>, 15 years ago

Attachment: 8619_split_long_methods_in_workflow​ added

comment:1 by Remy Blank, 15 years ago

Milestone: → 0.12
Owner: set to Remy Blank

Looks good.

comment:2 by Remy Blank, 15 years ago

Resolution: → fixed
Status: new → closed

On second read, I found the method not that unreadable, so I only kept _is_action_allowed() as a separate method. Applied in [8544].

comment:3 by Remy Blank, 15 years ago

Owner: changed from Remy Blank to Felix Schwarz <felix.schwarz@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Felix Schwarz <felix.schwarz@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Felix Schwarz <felix.schwarz@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.