obsolete JQuery in trac.js

[B.Ogryczak@…]

trac.js uses JQuery's 1.1 [@selectors], which are considered deprecated in JQuery 1.2, and fail completely in current version of JQuery (1.3).

Patch:

--- trac.js.orig        2009-08-24 15:15:45.000000000 +0200
+++ trac.js     2009-08-24 15:14:19.000000000 +0200
@@ -2,7 +2,7 @@

   $.fn.addAnchor = function(title) {
     title = title || "Link here";
-    return this.filter("*[@id]").each(function() {
+    return this.filter("*[id]").each(function() {
       $("<a class='anchor'> \u00B6</a>").attr("href", "#" + this.id)
         .attr("title", title).appendTo(this);
     });
@@ -25,7 +25,7 @@
       this.disabled = !enabled;
       var label = $(this).parents("label");
       if (!label.length && this.id) {
-        label = $("label[@for='" + this.id + "']");
+        label = $("label[for='" + this.id + "']");
       }
       if (!enabled) {
         label.addClass("disabled");

[Remy Blank]

Yep, and that was fixed in trunk (see [7982]), which has JQuery 1.3. In #7982 it was decided to leave 0.11-stable at 1.2.

[Christian Boos]

Yes, but…

[Christian Boos]

I think we can find a middle ground: making Trac itself compatible with jQuery 1.3 and still bundle jQuery 1.2.6.

That way, people knowing they don't use any problematic plugin can upgrade by themselves to jQuery 1.3 simply by replacing jquery.js.

[Christian Boos]

And the other ticket was #8511 ;-)

[B.Ogryczak@…]

Replying to rblank:

Yep, and that was fixed in trunk (see [7982]), which has JQuery 1.3. In #7982 it was decided to leave 0.11-stable at 1.2.

Ok, but even in 1.2 it already is deprecated. This is JQuery 1.1 syntax. Correct JQuery 1.2 syntax is without @.

I believe it should be backported to 0.11.

[anonymous]

Replying to cboos:

I think we can find a middle ground: making Trac itself compatible with jQuery 1.3 and still bundle jQuery 1.2.6.

That way, people knowing they don't use any problematic plugin can upgrade by themselves to jQuery 1.3 simply by replacing jquery.js.

Exaclly. JQuery 1.2 code is compatible with 1.3. What I'm complaining about is JQuery 1.1 code.

[Remy Blank]

Replying to cboos:

I think we can find a middle ground: making Trac itself compatible with jQuery 1.3 and still bundle jQuery 1.2.6.

Fair enough. I just didn't see this as fitting the ​"only considering serious bug fixes and eventually performance tweaks" criterion.

[Christian Boos]

It passes the "eventually performance tweaks" one ;-)

So…

Relevant parts of r7982 backported in r8503, unfortunately the svn:mergeinfo property change for this already appears in r8502, as I played with several patches and forgot about the property change…