URL hex encoding in Query.to_string()

[ebray]

When I save a custom query containing a filter such as "summary=~foo", it's displayed in the save report page as "summary=%7Efoo". I know that this is due to Query.to_string() just being a thin wrapper around Query.get_href(). But I thought that at least this was fixed a long time ago. Is this a regression, or was it never fixed?

I simply modified my to_string to wrap the call to self.get_href() in unicode_unquote(). That solves the problem nicely, and doesn't seem to have any adverse effects.

You'd think there'd be a ticket addressing this somewhere, but I couldn't find one.

[Remy Blank]

I'll check that. Thanks for reporting the issue.

[ebray]

Yeah, I actually fixed this several months ago in my branch of Trac:

trac/trac/ticket/query.py

@@ -35 +35 @@
 from trac.util.datefmt import to_timestamp, utc
 from trac.util.presentation import Paginator
-from trac.util.text import shorten_line
+from trac.util.text import shorten_line, unicode_unquote
 from trac.util.translation import _
 from trac.web import parse_query_string, IRequestHandler
@@ -376 +376 @@
         expressed in TracQuery language.
         """
-        query_string = self.get_href(Href(''))
+        query_string = unicode_unquote(self.get_href(Href('')))
         if query_string and '?' in query_string:
             query_string = query_string.split('?', 1)[1]

[Remy Blank]

No side-effects here either, so I guess it's ok. Patch committed in [8465]. Strangely, except for the cosmetic factor, it was also working correctly before. Does this mean that the following URLs are actually equivalent?

http://example.com/trac?summary=~foo
http://example.com/trac?summary=%7Efoo

Too tired to read RFCs…

[anonymous]

There is another query.get_href at line 822 and it breaks *some* queries in *some* browsers. Changing

req.redirect(query.get_href(req.href))

to

req.redirect(unicode_unquote(query.get_href(req.href)))

seems to fix it.

[Christian Boos]

Care to give *some* example that we could integrate in a test?

[Remy Blank]

This change caused #9965, so I will revert it, while still trying to keep the query readable.

[spamgy@…]

Help… I've 1.0.1 version as different projects. When I put latin letters into summary field all is o'k, but if I put russian letters there - it recodes into percentage format and searches nothing. If put russian letters into URL string - search works o'k. What I do wrong?

[ebray]

I wonder if rather than reopening a 5 year old ticket it wouldn't be better to create a new one if this is truly a regression. I wonder if it's a browser-specific bug. I couldn't reproduce this on the latest Firefox.

[Remy Blank]

Indeed. Please open a new bug with a precise description of how to reproduce the issue and the symptoms you observe.