Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

#8542 closed enhancement (wontfix)

[PATCH][trac-post-commit-hook] lists within commit messages

Reported by: tuebernickel@… Owned by:
Priority: normal Milestone:
Component: ticket system Version: none
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Scenario

A commit message containing a list is send via svn to the trac-post-commit-hook. For example:

 * use ajaxMessage on ajax requests
 * only hide ajaxMessage in user interface (see #5431) 

This will result e.g. in the following comment in the ticket:

 (In [12541]) * use ajaxMessage on ajax requests
 * only hide ajaxMessage in user interface (see #5431)

Turns out, the first list element is not within the list of the mark up. However second item and counting are within a list with correct markup.

Enhancement

The requested enhancement is to make it available to use these listed commit messages and make the whole list available in the view.

Solution

So far, my suggestion would be this patch on r8427:

155c155,158
<         self.msg = "(In [%s]) %s" % (rev, chgset.message)
---
>         if chgset.message[0:2] == " *":
>             self.msg = "(In [%s])\n%s" % (rev, chgset.message)
>         else:
>             self.msg = "(In [%s]) %s" % (rev, chgset.message)

Attachments (0)

Change History (1)

comment:1 by Remy Blank, 13 years ago

Resolution: wontfix
Status: newclosed

The post-commit script has been changed to a plugin and enhanced in the multirepos branch, to be merged to trunk pretty soon and released as 0.12. In particular, this issue does not apply anymore to the new version. So I'm closing this ticket as wontfix, as we will not update the old script in 0.11-stable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.