"Older Revisions" link with revision list is wrong

[Remy Blank]

When viewing a revision log with a long (resulting in more than one page), discontinuous list of revisions, where the url is typically:

/log/trunk?revs=1-5,7,9,11,13-22

the "Older Revisions" link drops the revision list, and results in displaying the full log starting from the oldest revision on the first page. Somehow, the revision list is lost.

[Christian Boos]

Maybe even for 0.11.6.

[Christian Boos]

Two other improvements related to discontinuous ranges of revisions:

• revisions not belonging to the path should be ignored instead of appearing as empty rows
• there shouldn't be a global View changes form, but rather one per range (otherwise one can create a diff containing changes from revisions not present in the displayed list)

[Christian Boos]

Another related improvement: if multiple changesets or ranges are given but there's actually no gap between those changesets or ranges, the rows should appear as a single range.

[Christian Boos]

The log options form should also take the revision list into account, in particular when updating the limit value.

[Christian Boos]

I've started working on this.

Prior to the changes mentioned above, I've done a few clean-ups in the log module:

• in path history mode
  • fixed row depth [8404]
  • fixed links [8405]
• more consistent use of revranges in LogModule.process_request [8406]
• respect strictly the revs parameter when given; fix log TracLinks accordingly [8407] (+ Python 2.3 fix only for 0.11.6dev, [8408])
• fix TracLinks ranges given in reverse order [8409]
• small refactorings [8410], [8411]
• clarify use of Diff column [8412] (see #4083)

[Christian Boos]

And finally, fixed "older revisions" links and propagate revs when updating log options (comment:4), in [8413].

There are still comment:2 and comment:3 items to do.

[Remy Blank]

Replying to cboos:

I've started working on this.

I had started as well, but didn't manage to go very far, so I'm glad you took this up.

I have fixed the parent directory link in the log view in [8420] (that's about as far as I went, really). Speaking about the path_links array: shouldn't it point to /log instead of /browser in the log view?

[Christian Boos]

Replying to rblank:

Speaking about the path_links array: shouldn't it point to /log instead of /browser in the log view?

Yes, that would be better, but we should do that on trunk only, as it's a quite big ui change. I'm on the way to sync trunk, then multirepos.

Note that I hesitated for a moment to make all the [8400:8419] changes to 0.11-stable, but as they were "on the way" to the fixes for 2 major tickets we decided to fix for 0.11.6, I preferred to go the simplest way. We're far enough from the actual 0.11.6 release so this shouldn't present a big risk…

[Christian Boos]

Ticket finalized:

• comment:2 implemented in r8482 and r8483
• CSS tweaks done in r8484 and r8485
• comment:3 implemented in r8487, which also reworks the former changes a bit
• more testing and final fix committed as r8488

Note that with all those changes in place, it's now possible to tweak the path in the URL and still get a meaningful display of the revision ranges, as only the revisions belonging to the path will be shown, with ranges coalescing as needed.

This is especially useful when looking at eligible changesets, when one wants to narrow a possibly long list of changesets to only those belonging to a path of interest (merge of a given subsystem).

In the future, it might be interesting to add a text field with autocompletion below the path, in order to easily navigate further down the tree while preserving the current revranges.