Deleting a Milestone via Admin panel leaves an Anonymous comment in tickets

[anonymous]

When you delete a milestone, the admin panel calls delete() on the Milestone model. That method leaves a comment in any tickets that have that milestone and accepts an author parameter. The ticket system admin panel for milestones does not provide the author parameter. Here is a proposed patch:

--- trac/ticket/admin.py.orig	2009-04-28 08:22:40.000000000 -0700
+++ trac/ticket/admin.py	2009-04-28 08:24:30.000000000 -0700
@@ -272,7 +272,7 @@
                     db = self.env.get_db_cnx()
                     for name in sel:
                         mil = model.Milestone(self.env, name, db=db)
-                        mil.delete(db=db)
+                        mil.delete(db=db, author=req.authname)
                     db.commit()
                     req.redirect(req.href.admin(cat, page))

[Remy Blank]

Yep, I noticed this the other day, too. Good idea, and thanks for the patch.

[Remy Blank]

Patch applied in [8161], together with a regression test.