Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

#8247 closed defect (fixed)

Deleting a Milestone via Admin panel leaves an Anonymous comment in tickets

Reported by: anonymous Owned by: Remy Blank
Priority: normal Milestone: 0.11.5
Component: ticket system Version: 0.11.4
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When you delete a milestone, the admin panel calls delete() on the Milestone model. That method leaves a comment in any tickets that have that milestone and accepts an author parameter. The ticket system admin panel for milestones does not provide the author parameter. Here is a proposed patch:

--- trac/ticket/admin.py.orig	2009-04-28 08:22:40.000000000 -0700
+++ trac/ticket/admin.py	2009-04-28 08:24:30.000000000 -0700
@@ -272,7 +272,7 @@
                     db = self.env.get_db_cnx()
                     for name in sel:
                         mil = model.Milestone(self.env, name, db=db)
-                        mil.delete(db=db)
+                        mil.delete(db=db, author=req.authname)
                     db.commit()
                     req.redirect(req.href.admin(cat, page))

Attachments (0)

Change History (2)

comment:1 by Remy Blank, 13 years ago

Milestone: 0.11.5
Owner: set to Remy Blank

Yep, I noticed this the other day, too. Good idea, and thanks for the patch.

comment:2 by Remy Blank, 13 years ago

Resolution: fixed
Status: newclosed

Patch applied in [8161], together with a regression test.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.