Trac breaks my browser's "UP" button

[Noah Slater]

If you are viewing a source file and you use the "Up" button provided by some browsers you get an error and a Python backtrace.

Efectively what the "Up" button does is try to traverse one folder up in the sites heirachy.

This should work and I think it is bad usability that it doesn't. Anything which breaks a user-agents expected behaviour is a Bad Thing in my opinion.

[Christopher Lenz]

Reproduced. Here's the stack trace:

 Traceback (most recent call last):
  File "/usr/lib/python2.2/site-packages/trac/ModPythonHandler.py", line 191, in handler
    core.dispatch_request(mpr.path_info, args, mpr, env)
  File "/usr/lib/python2.2/site-packages/trac/core.py", line 433, in dispatch_request
    module.run()
  File "/usr/lib/python2.2/site-packages/trac/Module.py", line 45, in run
    self.render()
  File "/usr/lib/python2.2/site-packages/trac/File.py", line 311, in render
    self.length = svn.fs.file_length(root, self.path, self.pool)
SubversionException: ('Attempted to get length of a *non*-file node', 160017)

I gotta note here that the Google toolbar is really stupid in not using the <link rel="up"> we are already providing for such purposes. Oh the ignorance.

[Noah]

Good point about Googles toolbar.

I am using Konqueror. While not being a *very* popular user-agent, it is one non the less that has decided to simply "move" up a dir with it's "up" button.

[Matthew Good <matt-good.net>]

But, of course if you're browsing the text source of a file, there's no way to provide a <link rel="up"/>. Two options I see here are either to make the File module redirect back to the Browser if trying to load a directory, or combine the two so they use a single path and choose the display based on whether you're browsing a file or directory.

[Jaa]

You get the same result if you try access directly an url which will end at the directory, e.g. ​contrib

[Christopher Lenz]

This has been fixed with the merging of the versioncontrol layer in [1413]. Both files and directories and now handled through the /browser/<path> URL. (The older /file/<path> style URLs are redirected for backwards compatibility).