Edgewall Software
Modify

Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#8121 closed enhancement (fixed)

[PATCH] Show matching regular expressions

Reported by: mrenzmann@… Owned by: mrenzmann@…
Priority: normal Milestone: not applicable
Component: plugin/spamfilter Version: none
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The attached patch updates the regex filter such that if submitted content gets blocked because of matching patterns it will list those patterns.

I wrote it while investigating reports from users of trac-hacks.org saying that (harmless / non-spamy) submissions were blocked because of some blacklisted pattern. Since our BadContent page contains ~1800 patterns, parsing them mentally to find the culprit was actually no option.

The patch probably requires some more love before it can be committed upstream, but it may at least serve as a prototype.

Attachments (1)

show-matching-patterns.diff (961 bytes ) - added by mrenzmann@… 16 years ago.

Download all attachments as: .zip

Change History (6)

by mrenzmann@…, 16 years ago

Attachment: show-matching-patterns.diff added

comment:1 by Christian Boos, 16 years ago

Milestone: not applicable

Sounds useful.

Michael, as you're an expert "Spam fighter" if I recall correctly, would you like to participate to the maintenance of the SpamFilter? (otherwise that patch might never get applied…)

in reply to:  1 comment:2 by mrenzmann@…, 16 years ago

Replying to cboos:

Michael, as you're an expert "Spam fighter" if I recall correctly,

I'd not call me an expert in that regard, but due to authoring ScallyWhack I have at least some experience with fighting spam that hits Trac instances. :)

would you like to participate to the maintenance of the SpamFilter?

Yes, that would be great.

comment:3 by anonymous, 16 years ago

Summary: Show matching regular expressions[PATCH] Show matching regular expressions

Tested this for some month now and found it very useful!

P.S. I'm the same anon as in #8257.

comment:4 by Christian Boos, 15 years ago

Resolution: fixed
Status: newclosed

Patch applied as is in r8328, as others found it useful.

Michael, if you'd like to refine this further, please do so!

comment:5 by Christian Boos, 15 years ago

Owner: set to mrenzmann@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain mrenzmann@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mrenzmann@… to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.