Edgewall Software
Modify

Opened 11 years ago

Closed 11 years ago

#8257 closed defect (fixed)

[patch] SpamFilter for Wiki pages defective (at least with >= 0.11.3)

Reported by: anonymous Owned by: Christian Boos
Priority: high Milestone: not applicable
Component: plugin/spamfilter Version: none
Severity: major Keywords: IWikiPageManipulator
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I had the problem, that SPAM on the WIKI pages got not filtered with the Trac spam plugin so I searched the reason. Following fix seems to cure that problem:

Index: tracspamfilter/adapters.py
===================================================================
--- tracspamfilter/adapters.py  (revision 8172)
+++ tracspamfilter/adapters.py  (working copy)
@@ -90,7 +90,7 @@
         comment = req.args['comment']

         # Test the actual page changes as well as the comment
-        changes = [(cur_page.text, page.text), (None, author)]
+        changes = [(cur_page.text, req.args['text']), (None, author)]
         if comment:
             changes += [(None, comment)]

Reason: The SPAM checker text should be the difference between old and new. Currently used is the difference between old and old (probably the filtering process was modified slightly in the past?).

Attachments (0)

Change History (11)

comment:1 by anonymous, 11 years ago

Probably this is also the reason for #4942.

comment:2 by Christian Boos, 11 years ago

Milestone: not applicable

comment:3 by anonymous, 11 years ago

Is there anyone working on the spam-filter anymore? The last change has been made 9 month ago.

This is a core component of Trac, so this should work as expected.

comment:4 by Christian Boos, 11 years ago

comment:5 by peter@…, 11 years ago

I can verify that I've seen behavior like this with the spam-filter and wiki entries on our public Trac installation for an open-source project. The spam-filter monitor only shows the username / email address as the checked "content" so if the anonymous ticket filer is right — this would fix the issue.

comment:6 by anonymous, 11 years ago

What should the link to HowToContribute tell me? Without SVN account the patch I supplied is the maximum I can do. And now 2 months later it is still not applied.

in reply to:  6 comment:7 by Christian Boos, 11 years ago

Keywords: IWikiPageManipulator added
Owner: set to Christian Boos
Status: newassigned

Replying to anonymous:

What should the link to HowToContribute tell me? Without SVN account the patch I supplied is the maximum I can do.

Dear anonymous, it was not obvious you were the same anonymous that posted the patch, so the HowToContribute link was a general answer to the general address of "is anyone working on the spam-filter?"…

comment:8 by Christian Boos, 11 years ago

Resolution: fixed
Status: assignedclosed

Adapted patch applied in r8320 for the spam-filter branch, ported to spam-filter-captcha in r8321.

Please test and confirm the fix worked.

See also #7731 for the issue with IWikiPageManipulator.

comment:9 by Christian Boos, 11 years ago

Make that r8322/r8323.

comment:10 by anonymous, 11 years ago

Resolution: fixed
Status: closedreopened

I fear you need to reverse the arguments. At least first test indicate it and compared to my fix you reversed the two.

comment:11 by Christian Boos, 11 years ago

Resolution: fixed
Status: reopenedclosed

Indeed… fixed in r8326/r8327. Thanks for testing!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.