Default language setting in trac.ini

[alexey.rudy@…]

I haven't found the way to enforce default language. Now language selection based on Accept-Language header from browser, but sometimes that's not convinient.

I suggest to add extra setting to trac.ini:

[trac]
lang = ru

This setting will have higher priority than headers data. Patch is attached: patch_from_r7937.diff​

[alexey.rudy@…]

patch for setting defaulf language in trac.ini

[Christian Boos]

Any reason why you can't simply select the language you want from the users preferences? That will also take precedence over the Accept-Language headers.

[alexey.rudy@…]

Replying to cboos:

Any reason why you can't simply select the language you want from the users preferences? That will also take precedence over the Accept-Language headers.

Yes, I can :) But I want all other users to see the site in particular language by default. They are just users and they don't need to do extra actions.

For example - when I do public wiki in Russian not for hardcore programmers :) That looks strange when site content is in Russian and the interface is in English. And I need to explain everyone that they need to change their language in preferences. It's better to switch always to Russian in such case.

My first suggested implementation is wrong - the setting in trac.ini will override session settings too. It would be right to override only browser headres data. Sorry :))

[alexey.rudy@…]

patch for setting defaulf language in trac.ini, version 2

[Christian Boos]

Ok, but the change should be rewritten so that the lookup in config could be done only if there's nothing stored in the session.

[Christian Boos]

Can wait for 0.12.1.

[nzoltan]

I also would like to see this feature, this would be very useful.

[Christian Boos]

No new enhancements for 0.12.x. This one shouldn't be hard to get in shape for trunk (comment:3), so moving to 0.13 directly.

[Christian Boos]

I'd like to make an exception for this feature, and get it in 0.12.1 nevertheless.

Updated patch follows.

[Christian Boos]

enable a default language to be configured in TracIni (based on r10044)

[Remy Blank]

Replying to cboos:

I'd like to make an exception for this feature, and get it in 0.12.1 nevertheless.

He he, changed your mind? :)

Any chance of using the same setting to set the language used by trac-admin? Currently, with my custom locale en_CH, trac-admin outputs text in German for some mysterious reason, even though German is mentioned nowhere in the locale. Begin able to set it to "en" and having trac-admin talk to me in English would be awesome.

[Christian Boos]

Replying to rblank:

Replying to cboos:

I'd like to make an exception for this feature, and get it in 0.12.1 nevertheless.

He he, changed your mind? :)

Personal reason ;-) But I'd really like that it remains an exception…

Any chance of using the same setting to set the language used by trac-admin? Currently, with my custom locale en_CH, trac-admin outputs text in German for some mysterious reason, even though German is mentioned nowhere in the locale.

That's because of Babel, the following:

>>> import babel
>>> babel.Locale.default()

must give you 'de'.

Being able to set it to "en" and having trac-admin talk to me in English would be awesome.

Yup, see 8117-trac-admin-default_language.patch​.

[Christian Boos]

reworked patch_from_r7937.2.2.diff​ in order to properly support values with undescores (e.g. 'zh_CN')

[Christian Boos]

trac-admin uses the default_language configured for the environment, if any; patch on top of 8117-trac-default_language.patch​

[Christian Boos]

Ok to apply?

[osimons]

Replying to cboos:

Ok to apply?

Haven't actually tried the patches, but they read well… I'd like to see this committed.

[Remy Blank]

Replying to cboos:

Ok to apply?

I haven't had a chance to test it yet either, but it reads well here, too. So yes, please go ahead.

[Christian Boos]

Reworked patches applied in [10052:10053], should work as expected, but testing always welcome.

[Christian Boos]

Well, when documenting the feature, r10053 feels a bit wrong, as we don't have a way to enforce a user preference anymore (e.g. LANG=en trac-admin ... or LANG=fr trac-admin ...).

Curiously, the above didn't work either before r10053, and this is because the precedence order in babel.Locale.default() is 'LANGUAGE', 'LC_ALL', 'LC_CTYPE', 'LANG' ([Babel:source:tags/0.9.5/babel/core.py@#L630 babel.core]).

This is somehow in accordance with ​http://www.gnu.org/software/gettext/manual/gettext.html#Users, however that documentation also refers to LANG as the normal environment variable for specifying a locale.

Babel has anyway other problems with the default, as it expects things like fr_FR and won't work with a simple LANG=fr.

Therefore I'd propose the following addition:

trac/admin/console.py

@@ -168 +168 @@
         self.__env = env = Environment(self.envname)
         # fixup language according to env settings
         if has_babel:
-            preferred = env.config.get('trac', 'default_language', '')
-            if preferred:
-                translation.activate(get_negotiated_locale([preferred]))
+            lang = os.environ.get('LANG')
+            default = env.config.get('trac', 'default_language', '')
+            negotiated = get_negotiated_locale([lang, default])
+            if negotiated:
+                translation.activate(negotiated)
 
     ##
     ## Utility methods

[Remy Blank]

Replying to cboos:

Therefore I'd propose the following addition:

There's still a little glitch here, as the locale is only set when opening the environment. However, the welcome banner is already printed at that point, so I get a banner in German and the rest in English. Of course, we cannot get the value of [trac] default_language before opening the environment, but we can at least use LANG.

How about the following addition:

trac/admin/console.py

@@ -524 +526 @@
     if has_babel:
         import babel
         try:
-            locale = babel.Locale.default()
+            locale = get_negotiated_locale([os.environ.get('LANG')]) \
+                     or babel.Locale.default()
         except babel.UnknownLocaleError:
             pass
         translation.activate(locale)

[Christian Boos]

Replying to rblank:

How about the following addition: …

Thanks! Both patches integrated in r10060.

[Ryan J Ollos]

In r10052, was it intended to have get_negotiate_locale have a different signature when Babel is present as compared to the non-Babel fallback?

This change would make the signatures the same:

trac/util/translation.py

@@ -402 +402 @@
     def get_available_locales():
         return []
 
-    def get_negotiated_locale(preferred=None, default=None):
+    def get_negotiated_locale(preferred_locales):
         return None

[Christian Boos]

Sounds good.

[Ryan J Ollos]

Thanks, committed to 1.0-stable in r15403, merged in r15404 and r15405.