Opened 16 years ago
Closed 16 years ago
#8033 closed defect (fixed)
'split_page_names' inserts spaces even when not rendering a link
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11.3 |
Component: | wiki system | Version: | 0.11.2.1 |
Severity: | minor | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
If, in your trac.ini, you set both 'split_page_names' and 'ignore_missing_pages' to True, then "CamelCase" will render properly as "Camel Case", but "NotACamelCaseLink" (an innocuous CamelCase string, not a link to a page) will render improperly, as "Not A Camel Case Link".
The split_page_names behavior is observed even when a CamelCase string is determined not to be an existing page.
I base my statement that this behavior is improper on the documentation on the CamelCase page (emphasis mine):
There's an option (split_page_names in [wiki]) to automatically insert space characters between the words of a CamelCase link when rendering the link.
This suggests that space characters should not be automatically inserted when a link is not rendered.
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
Milestone: | → 0.11.4 |
---|---|
Owner: | set to |
Severity: | trivial → minor |
Status: | new → assigned |
comment:2 by , 16 years ago
That is indeed the case…I was having trouble coming up with concise wording there. Thanks for the clarification.
by , 16 years ago
Attachment: | t8033-dont_split_missing_pages-r7824.patch added |
---|
patch on 0.11-stable
comment:3 by , 16 years ago
Milestone: | 0.11.4 → 0.11.3 |
---|
comment:4 by , 16 years ago
I just applied this to my 11.2.1 instance and I can confirm that this has been fixed.
Also, holy bejeebus that was fast. Thanks!
comment:5 by , 16 years ago
My apologies, I'm too used to my own trac that knows me so very well. All the above anonymous posts were made by me.
I guess you meant "CamelCaseButNotAnExistingWikiPage", as "NotACamelCase" is indeed not in CamelCase and therefore won't be recognized as a wiki link in the first place…
But yes, in the case of "CamelCaseButNotAnExistingWikiPage", when both 'split_page_names' and 'ignore_missing_pages' are set to True, space characters will be inserted and that's not correct, as you've explained.