Issue: Custom Query Shows All Milestones Closed and Active

[minhthel@…]

I realize this maybe intentional but it occured to me that when I do a custom query and search by milestone, EVERY milestone is shown in the dropdown. I understand it was meant to be exhaustive but the list is growing and growing after each successive release.

Would be great to only show current/active milestones in the dropdown as default but also, if needed, through a checkbox be able to show all milestones.

[Remy Blank]

Sorry, wrong milestone.

[Christian Boos]

Milestone 1.0 deleted

[Ismael de Esteban <ismael@…>]

Put milestones in select groups like ticket view. Make some tests to fail.

[Remy Blank]

Using the same grouping as in the milestone field of tickets might indeed be a good idea. I'll test the patch.

[Ismael de Esteban <ismael@…>]

This is the correct diff, the other one has two extra lines where ordered alphabetically the milestones 'By due date', that fits better my organization

[Ismael de Esteban <ismael@…>]

Found a bug in the last one. Uploading patch with fixed bug.

[Christian Boos]

Thanks for working on this, but please have a look at our TracDev/CodingStyle first. In particular, it seems you have a mix of tabs and spaces, use spaces only. Also, use more appropriate variable names (e.g. sel instead of e for the <select>).

[Erik Andersson <kirean@…>]

Are you working on Would be great to only show current/active milestones in the dropdown as default but also, if needed, through a checkbox be able to show all milestones. or Put milestones in select groups like ticket view.? Or a mix of both?

[Ismael de Esteban <ismael@…>]

Replying to cboos:

Thanks for working on this, but please have a look at our TracDev/CodingStyle first. In particular, it seems you have a mix of tabs and spaces, use spaces only. Also, use more appropriate variable names (e.g. sel instead of e for the <select>).

I'll have a look at it.

[Ismael de Esteban <ismael@…>]

Replying to Erik Andersson <kirean@…>:

Are you working on Would be great to only show current/active milestones in the dropdown as default but also, if needed, through a checkbox be able to show all milestones. or Put milestones in select groups like ticket view.? Or a mix of both?

I think the proper solution is a mix of both: Hide optionally the completed milestones and show grouped and ordered the active ones. I'm only doing Put milestones in select groups like ticket view.

Don't mind if this patch is discarded in the end, but it can be a solution patch for the meantime, or some start point for the desired solution.

[Ismael de Esteban <ismael@…>]

Replying to Ismael de Esteban <ismael@…>:

Replying to cboos:

Thanks for working on this, but please have a look at our TracDev/CodingStyle first. In particular, it seems you have a mix of tabs and spaces, use spaces only. Also, use more appropriate variable names (e.g. sel instead of e for the <select>).

I'll have a look at it.

About the e for <select>, I got it from: ​http://trac.edgewall.org/browser/trunk/trac/htdocs/js/query.js#L99

How should I proceed?

[Christian Boos]

Replying to Ismael de Esteban <ismael@…>:

… How should I proceed?

Use sel in the new code, don't change the unrelated code. Or better, look at unifying your new createSelectGroup with createSelect, if possible.

[Ismael de Esteban <ismael@…>]

Bugfix: Not showing group by Milestone. Following coding standards.

[Ismael de Esteban <ismael@…>]

Replying to cboos:

Replying to Ismael de Esteban <ismael@…>:

… How should I proceed?

Use sel in the new code, don't change the unrelated code. Or better, look at unifying your new createSelectGroup with createSelect, if possible.

That's feasible but will obfuscate the code a little I think.

[Remy Blank]

Group milestones in the ticket query selectors.

[Remy Blank]

Nice patch, thanks! Adding a whole new "optgroup" field type was not the simplest solution, however. Adding an "optgroup" key to "select" fields makes the code much simpler, and we already do the same on the ticket page. The result is in 7895-group-milestones-r10139.patch​.

One difference with the previous behavior is that only milestones for which the user has MILESTONE_VIEW are shown in the selector. Previously, all milestones were shown. This is now consistent with the ticket page.

Please test and let me know if the result is what you expect.

[Remy Blank]

Patch applied in [10153].

For the "only show active milestones, and closed milestones with a checkbox", I'm still waiting for UI suggestions / sample implementations.

[Remy Blank]

[10153] broke the [[TicketQuery()]] macro, due to the permission check in Query.template_data(). This is fixed in [10175].

[Christian Boos]

Replying to rblank:

[10153] broke the [[TicketQuery()]] macro, due to the permission check in Query.template_data(). This is fixed in [10175].

A better fix would be to use context.perm for the check?

[Remy Blank]

Possibly. If req is None, the generated milestone data isn't used anyway, so this won't make a difference. I didn't look much further either, because template_data() mixes plain data generation and side-effects, and would be in need of a good refactoring.

I'll make the change tonight.

[Remy Blank]

Better fix in [10198].

[Remy Blank]

No suggestions for the UI of "only show active milestones, and closed milestones with a checkbox", so this moves back to unscheduled.