Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#7885 closed defect (worksforme)

links to changesets/tickets in timeline do not use base_url from trac.ini

Reported by: anonymous Owned by:
Priority: normal Milestone:
Component: timeline Version: 0.11.2
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

base_url in trac.ini is set to https://foo.com/trac/myproj

a reverse proxy (pound) publishes trac timeline as https://foo.com/trac/myproj/timeline

ssl is terminated at the reverse proxy and requests are forwarded to internal server at http://10.5.5.1/trac/myproj/timeline

now, when clicking on a changeset or ticket link in the timeline, the link will point to http://foo.com/trac/myproj/… instead of to https://foo.com/trac/myproj/

links in non-timeline pages are OK and do use the correct https baseurl

Attachments (0)

Change History (7)

comment:1 by anonymous, 14 years ago

forgot: Ubuntu Linux 7.04 Python 2.5

comment:2 by anonymous, 14 years ago

maybe also useful: with trac 0.10.x and the same reverse proxy, the problem did not occur

comment:3 by anonymous, 14 years ago

the problem seems to go away when the following changes are applied:

file: user/lib/python2.5/site-packages/Trac-011.2-py2.5.egg/trac/timeline/web_ui.py

line 182: rss_context = Context.from_request(req, absurls=False)

line 188: html_context = Context.from_request(req, absurls=False)

seems to be a workable solution, but have to say I am not familiar enough with the source to judge if this is the best way to fix though…

(offtopic: I absolutely love trac - great product!)

comment:4 by Remy Blank, 14 years ago

The fix on line 188 has been committed in [7754]. But I'm not sure if the one on line 182 is correct. Christian?

in reply to:  4 comment:5 by osimons, 14 years ago

Replying to rblank:

The fix on line 188 has been committed in [7754]. But I'm not sure if the one on line 182 is correct. Christian?

Line 182 looks good to me. For RSS feeds we neeed absolute URLs as they need to work outside server context. I've tested both and they work fine now.

comment:6 by Christian Boos, 14 years ago

Yes, 188 was just a copy/paste from 182 and I forgot to clear the absurls=True parameter which is needed for RSS feeds, so r7754 corrects it to:

  • line 182, rss_contextabsurls=True
  • line 188, html_contextabsurls=False, or no parameter, as it's the default

comment:7 by Remy Blank, 14 years ago

Milestone: 0.11.3
Resolution: worksforme
Status: newclosed

Ok, I guess it's a worksforme, then.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.