links to changesets/tickets in timeline do not use base_url from trac.ini

[anonymous]

base_url in trac.ini is set to ​https://foo.com/trac/myproj

a reverse proxy (pound) publishes trac timeline as ​https://foo.com/trac/myproj/timeline

ssl is terminated at the reverse proxy and requests are forwarded to internal server at ​http://10.5.5.1/trac/myproj/timeline

now, when clicking on a changeset or ticket link in the timeline, the link will point to ​http://foo.com/trac/myproj/… instead of to ​https://foo.com/trac/myproj/…

links in non-timeline pages are OK and do use the correct https baseurl

[anonymous]

forgot: Ubuntu Linux 7.04 Python 2.5

[anonymous]

maybe also useful: with trac 0.10.x and the same reverse proxy, the problem did not occur

[anonymous]

the problem seems to go away when the following changes are applied:

file: user/lib/python2.5/site-packages/Trac-011.2-py2.5.egg/trac/timeline/web_ui.py

line 182: rss_context = Context.from_request(req, absurls=False)

line 188: html_context = Context.from_request(req, absurls=False)

seems to be a workable solution, but have to say I am not familiar enough with the source to judge if this is the best way to fix though…

(offtopic: I absolutely love trac - great product!)

[Remy Blank]

The fix on line 188 has been committed in [7754]. But I'm not sure if the one on line 182 is correct. Christian?

[osimons]

Replying to rblank:

The fix on line 188 has been committed in [7754]. But I'm not sure if the one on line 182 is correct. Christian?

Line 182 looks good to me. For RSS feeds we neeed absolute URLs as they need to work outside server context. I've tested both and they work fine now.

[Christian Boos]

Yes, 188 was just a copy/paste from 182 and I forgot to clear the absurls=True parameter which is needed for RSS feeds, so r7754 corrects it to:

• line 182, rss_context → absurls=True
• line 188, html_context → absurls=False, or no parameter, as it's the default

[Remy Blank]

Ok, I guess it's a worksforme, then.