Don't add panel providers which do not provide a label to be rendered

[Pedro Algarvio, aka, s0undt3ch]

Sometimes one might want his plugin to be able to handle some requests, yet, he might not want it to show on the admin pannels.

For example, on a plugin I'm currently working on I have 2 of those, one is downloads, but since that one is just serving files no active/not active panel rending checks is done, but, for the other one, it's supposed to a sub page and those active/ not active checks are rendered, making some un-useful empty html, like the screenshot attached(the one on the right, the one on the left is with this patch applied). A simple change on this code will do the trick:

trac/admin/web_ui.py

@@ -135 +136 @@
             'panels': [{
                 'category': {'id': panel[0], 'label': panel[1]},
                 'panel': {'id': panel[2], 'label': panel[3]}
-            } for panel in panels]
+            } for panel in panels if panel[3]]
         })
 
         add_stylesheet(req, 'common/css/admin.css')

[Noah Kantrowitz]

You should be using a request handler for this, not an admin panel.

[Pedro Algarvio, aka, s0undt3ch]

Replying to nkantrowitz:

You should be using a request handler for this, not an admin panel.

Even if I'm still rendering an admin page?