#7475 closed defect (fixed)
Cosmetic bug in mainnav bar background
Reported by: | Owned by: | Remy Blank | |
---|---|---|---|
Priority: | low | Milestone: | 0.11.2 |
Component: | general | Version: | 0.11 |
Severity: | trivial | Keywords: | patch |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The background of the mainnav
bar is defined by two images, one for the selected tab and one for the others. The size of the images is 128x32 pixels. On screens with dpi > 96, some tabs exceed a width of 128 pixels ("Browse Source", "View Tickets", "New Ticket"), leading to the background repeating horizontally. This shows a visual bug in the selected tab (a grey vertical bar). The first attachment below shows the problem.
Attachments (3)
Change History (7)
by , 16 years ago
Attachment: | trac-mainnav-background-bug.png added |
---|
by , 16 years ago
Attachment: | topbar_gradient2.png added |
---|
Horizontally expanded background for active tab
comment:1 by , 16 years ago
Since the image is just a vertical gradient, wouldn't it be more appropriate to have it be just 1px wide and tiled/stretched as necessary?
comment:2 by , 16 years ago
(Wow, that reply was fast!)
The attachment:topbar_gradient2.png is an expanded version of the original background. I repeated the rightmost pixel column until the width of the image was 192 pixels.
While not strictly necessary, I performed the same operation for attachment:topbar_gradient.png for consistency.
The original image is not strictly a gradient. There is a bevel on the top and on the left of the image. But yes, maybe it should be converted to an image that can be repeated seamlessly horizontally.
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
A double-width topbar_gradient2.png
image has been committed in [7470]. topbar_gradient.png
already repeats seamlessly, so it was not changed.
comment:4 by , 16 years ago
Milestone: | → 0.11.2 |
---|---|
Owner: | set to |
Screenshot showing the grey vertical bar in the active tab