Edgewall Software
Modify

Opened 11 years ago

Closed 11 years ago

#7332 closed defect (fixed)

Weird markup renders wrong on trac.edgewall.org and crashes trac v0.10.4

Reported by: nathan.collins@… Owned by: Jonas Borgström
Priority: high Milestone: 0.10.5
Component: wiki system Version:
Severity: blocker Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

If I put

x:"<x" Don't see this

Do see this.

on the trac.edgewall.org/wiki/SandBox and hit preview it renders as

x:"

Do see this.

If I put

x:"<x"

on my v0.10.4 trac on ubuntu 8.04 and hit preview I get "Trac detected an internal error:" in an otherwise empty red box, and the stack trace

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 406, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 244, in dispatch
    req.display(template, content_type or 'text/html')
  File "/usr/lib/python2.5/site-packages/trac/web/api.py", line 358, in display
    data = self.hdf.render(template, form_token)
  File "/usr/lib/python2.5/site-packages/trac/web/clearsilver.py", line 296, in render
    injector.feed(template.render())
  File "/usr/lib/python2.5/HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "/usr/lib/python2.5/HTMLParser.py", line 148, in goahead
    k = self.parse_starttag(i)
  File "/usr/lib/python2.5/HTMLParser.py", line 226, in parse_starttag
    endpos = self.check_for_whole_start_tag(i)
  File "/usr/lib/python2.5/HTMLParser.py", line 301, in check_for_whole_start_tag
    self.error("malformed start tag")
  File "/usr/lib/python2.5/HTMLParser.py", line 115, in error
    raise HTMLParseError(message, self.getpos())
HTMLParseError: malformed start tag, at line 65, column 6

My weird string x:"<x" is the most simplified form I could come up with of some text that was causing the above error on my trav v0.10.4.

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 11 years ago

Milestone: 0.11
Priority: normalhigh
Severity: normalblocker

Looks indeed serious.

comment:2 by Christian Boos, 11 years ago

Component: generalwiki system
Milestone: 0.110.10.5
Resolution: fixed
Status: newclosed

Fixed in r7205 for 0.11, r7207 for 0.10.5 and r7211 for 0.12.

I set the milestone of this ticket to 0.10.5, as one can then assume that it's fixed in later versions.

Again, many thanks for reporting this issue!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.