Search bar/button appears over banner image

[Jason Winnebeck <jpwasp@…>]

After upgrading from r7086 of 0.11-stable to r7166, now the search bar appears on the left over the banner image, instead of right-justified. I tried reloading the page, thinking of possible cached CSS in my browser (Firefox 2), but still the search bar appears incorrectly.

[Jason Winnebeck <jpwasp@…>]

Based on debugging from the browser only (not looking at any Trac code), I found the following:

The problem appears to be this style code in trac.css:

/* Quick search */
#search {
 clear: both;
 font-size: 10px;
 height: 2.2em;
 margin: 0 0 1em;
 text-align: right;
}
#search input { font-size: 10px }
#search label { display: none }

However, the rendered output from Trac shows that the forms's ID is actually #quicksearch and not #search. I'm not sure which name was the original.

By inserting a custom CSS as the following:

#quicksearch {
 clear: both;
 font-size: 10px;
 height: 2.2em;
 margin: 0 0 1em;
 text-align: right;
}
#quicksearch input { font-size: 10px }
#quicksearch label { display: none }

My problem was solved. I did not try to update trac.css since I didn't want to touch the source for this problem, and my site was already using an additional custom CSS (I checked to make sure that was not the problem first).

[Jason Winnebeck <jpwasp@…>]

It actually appears that the latest changeset, r7166, created this problem. Looking at the diffs, the "name" was quicksearch and replaced the old id of "search".

[Jason Winnebeck <jpwasp@…>]

Looks like r7168 and r7172 fix this problem? I haven't tested it yet. ecarter and jhampton checked in changes, but I don't think they are aware of this ticket.

[Eli Carter]

Fixed in r7172 for 0.11-stable and r7173 for trunk.